585100 - Add a IsValueEmpty() const method in nsTextEditorState

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect, P5)

Description

[Mounir Lamouri (:mounir)]

At the moment, classes using nsTextEditorState, to know if their value string is the empty string, have to get the value with GetValue(nsAString) or get the value length with GetTextLength().
It would be great to have a way to know quickly (understand optimized) if the value is currently the empty string or not. I'm sure we can easily to better than the current way (GetValue() value.IsEmpty()) at least in some situations. For example, if the VALUE_CHANGED bit is set to false and HasAttr(kNamespace_None, nsGkAtoms::value) returns false, IsValueEmpty should return true.

Comment 1

[Mounir Lamouri (:mounir)]

I'm not really sure what I meant when I've open this bug. It seems to confuse nsHTMLInputElement and nsTextEditorState. Anyway, both now have a method to know if the value is empty.

Comment 2

[Mounir Lamouri (:mounir)]

nsTextEditorState::IsEmpty isn't really doing what could have been expected... :(

Comment 3

[(no longer active)]

(In reply to comment #2)
> nsTextEditorState::IsEmpty isn't really doing what could have been expected...
> :(

That's true.  :/

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Does TextControlState::HasNonEmptyValue() work for the original purpose?

But anyway, nobody working on the optimization (I mean new callers of it). So feel free to reopen this if it's not reasonable API.