585240 - Can't add message handlers by setting the onmessage property

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Aleksandr Dobkin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/534.3 (KHTML, like Gecko) Chrome/6.0.458.1 Safari/534.3
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b4pre) Gecko/20100806 Minefield/4.0b4pre

The window.onmessage event handler does not fire when the postMessage function is called.

Reproducible: Always

Steps to Reproduce:
1. Open an html file containing the following:

<script>
	window.onmessage = function(event) {
		alert(event.data);
	}
	
	window.postMessage("hello", "*");
</script>
Actual Results:  
Nothing happens.

Expected Results:  
A message box containing the words "hello".

Works as expected in Chrome.

Comment 1

[Aleksandr Dobkin]

Attachment: HTML testcase

Comment 2

[Nickolay_Ponomarev]

I can reproduce on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b6pre) Gecko/20100904 Firefox/4.0b6pre, seems valid.

Comment 3

[Boris Zbarsky [:bzbarsky]]

This has nothing to do with posting a message to itself, and everything to do with "onmessage" not being a property of windows in Gecko.  Using

  addEventListener("message", function() { /* whatever */ }, false);

works fine.

Comment 4

[Nickolay_Ponomarev]

Oops! Thanks for correcting me, bz!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Just adding to nsContentUtils::InitializeEventTable might be good enough to make this work....

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Add onmessage to nsDOMClassInfo...

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 472289 [details] [diff] [review]
patch

I don't know much about the on*-property code, but going from the diff it seems plausible.  rs=me seems about the right level of confidence.

What I presume is a big filter to check a string against a gazillion on*-names looks like it wants some sort of gperf-hash-like thing; I'm vaguely curious if anyone's ever filed a bug on doing that.

It would be marginally better form, I think, to use location.href instead of "*" for the target origin.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

We should just add onfoo properties to the interfaces, but that is larger change
than what I want to do in this bug.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/64d3f6db6544
http://hg.mozilla.org/mozilla-central/rev/f06a18912bb4