585247 - NSS coreconf: Add -rpath-link to LDFLAGS for Maemo / Scratchbox

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

When building for Maemo with the Scratchbox toolkit,
we need the -rpath-link linker flag even for standard
system directories such as /usr/lib and /lib.

Mozilla's tinderboxes pass the necessary -rpath-link
flag to Mozilla's configure script via the LDFLAGS
environment variable.  But Mozilla's build system
doesn't forward the externally received -rpath-link
flag to NSS's coreconf build system.

I studied Mozilla's build system and concluded that
it's nontrivial to have Mozilla pass the externally
received -rpath-link flag to NSS.  My proposed
workaround is to add the -rpath-link flag to NSS's
coreconf build system.

Notes on my patch:

1. Based on timeless's suggestion, I test the environment
variable _SBOX_DIR to detect Maemo (Scratchbox).  This is
also how JS detects Scratchbox:
http://mxr.mozilla.org/mozilla-central/search?string=SBOX_

2. Please verify the -rpath-link search path that I use
       /usr/lib:/lib
works for both Maemo 4 and Maemo 5.

blassey, if you're not familiar with Maemo development,
please ask the right person to review this patch.  Thanks.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch v1.1

Wrap a long comment line.

Comment 2

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (NSS 3.13)
and NSS_3_12_BRANCH (NSS 3.12.8).

Checking in Linux.mk;
/cvsroot/mozilla/security/coreconf/Linux.mk,v  <--  Linux.mk
new revision: 1.48; previous revision: 1.47
done

Checking in Linux.mk;
/cvsroot/mozilla/security/coreconf/Linux.mk,v  <--  Linux.mk
new revision: 1.45.2.2; previous revision: 1.45.2.1
done