Closed
Bug 585295
Opened 15 years ago
Closed 15 years ago
Broken GLContextProviderEGL.cpp compilation on mingw-w64
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jacek, Unassigned)
References
Details
Attachments
(2 files)
|
1.12 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
|
1.33 KB,
patch
|
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
A patch from bug 575469 broke compilation on mingw-w64 because it introduced pointer->int casts losing precision:
printf_stderr("EGL Config: %d [0x%08x]", (int)cfg, (PRUint32)cfg);
The attached patch fixes it by using "%p" format for pointers. While I was at this, I've also fixed warnings about comparing signed and unsigned integers in GLContext.h.
|
Reporter | |
Updated•15 years ago
|
Attachment #463784 -
Attachment is patch: true
Attachment #463784 -
Flags: review?(vladimir)
Comment on attachment 463784 [details] [diff] [review]
fix v1.0
>+ printf_stderr("EGL Config: %p [%p]", cfg, cfg);
No point in doing that, since it'll print the same value. Keep the first one as an int, please (doing whatever's needed to cast down a 64-bit pointer). [On X11, the config often matches a visual id, which is useful info to have.]
Attachment #463784 -
Flags: review?(vladimir) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
Thanks for the review. The attached version prints the pointer with "%d" and a proper cast.
|
|
Reporter | |
Updated•15 years ago
|
Attachment #464740 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #464740 -
Flags: approval2.0? → approval2.0+
|
|
Reporter | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•