585337 - [ko] Change favicon of Naver and Daum's search plugin

Status: RESOLVED FIXED

(Mozilla Localizations :: ko / Korean, defect)

Description

[Channy Yun [:channy]]

Attachment: Changing favicon of Daum and Naver for Firefox 3.x and 4.x

Favicons of Daum and Naver, Korean search plugin partners were changed.

http://www.naver.com/favicon.ico
http://www.daum.net/favicon.ico

So, I want to get review of attached patch for Firefox 3.x. and 4.x

Comment 1

[Channy Yun [:channy]]

Attachment: Changing resized favicon of Daum and Naver for Firefox 3.x and 4.x

I converted ico to png format and cleaned them with transparency.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 463816 [details] [diff] [review]
Changing resized favicon of Daum and Naver for Firefox 3.x and 4.x

r-, the data-url versions of the icons doesn't look like the icons on the sites. The naver one seems to have a real white in the green box, and the background on the daum one looks pretty horrid to me.

I'm not against taking this on both l10n-central and 1.9.2, but I don't think that it's worth the hassle on 1.9.1., let alone 1.9.0.

Comment 3

[Channy Yun [:channy]]

Attachment: Changing favicon of Daum and Naver for Firefox 3.6.x

I revised Daum's icon and want to fix it in Firefox 3.6.9.

Comment 4

[LegNeato]

This is not a blocker. If approved patches are ready before code freeze, feel free to ask for branch landing approval.

Comment 5

[Axel Hecht [:Pike]]

Why did this land without review in http://hg.mozilla.org/l10n-central/ko/rev/b23a0aa233ed?

PS: I still think the Naver logo is wrong with being transparent inside.

Comment 6

[Axel Hecht [:Pike]]

Hrm. interesting, the patch that landed has different icons than the one attached to this bug?

Comment 7

[Staś Małolepszy :stas]

Attachment: Screenshot of Daum's icon

Looks like the Daum's icon that landed is a bit different from the one in favicon.ico. The "D" is less rounded and doesn't have the shadow. Channy, did you change that on purpose?

Comment 8

[Channy Yun [:channy]]

Oops, It pushed my another working copy (including hg commit of this bug) by manual script with my real working copy. I'll regress and attach another patch soon. Sorry.

Comment 9

[Channy Yun [:channy]]

Attachment: Final patch by ico file for Daum and Naver icons

I resized ico to png file format because of file size (over 5kb). But, there are some differences on resizing. 

So I used primary icon files despite of large size. Please check again!

Comment 10

[Channy Yun [:channy]]

Attachment: Final patch by ico file for Daum and Naver icons

Comment 11

[Staś Małolepszy :stas]

Comment on attachment 466272 [details] [diff] [review]
Final patch by ico file for Daum and Naver icons

r=me. Please land this patch on 1.9.2 and central and sign off for 3.6.x and 4.0 beta. Thanks, Channy!

Comment 12

[Channy Yun [:channy]]

fixed.