[ko] Change favicon of Naver and Daum's search plugin

RESOLVED FIXED

Status

Mozilla Localizations
ko / Korean
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: channy, Assigned: channy)

Tracking

unspecified
x86
Windows XP

Firefox Tracking Flags

(blocking1.9.2 -)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 463814 [details] [diff] [review]
Changing favicon of Daum and Naver for Firefox 3.x and 4.x

Favicons of Daum and Naver, Korean search plugin partners were changed.

http://www.naver.com/favicon.ico
http://www.daum.net/favicon.ico

So, I want to get review of attached patch for Firefox 3.x. and 4.x
Attachment #463814 - Flags: approval1.9.0.next?
(Assignee)

Comment 1

7 years ago
Created attachment 463816 [details] [diff] [review]
Changing resized favicon of Daum and Naver for Firefox 3.x and 4.x

I converted ico to png format and cleaned them with transparency.
Attachment #463814 - Attachment is obsolete: true
Attachment #463816 - Flags: approval1.9.0.next?
Attachment #463814 - Flags: approval1.9.0.next?

Comment 2

7 years ago
Comment on attachment 463816 [details] [diff] [review]
Changing resized favicon of Daum and Naver for Firefox 3.x and 4.x

r-, the data-url versions of the icons doesn't look like the icons on the sites. The naver one seems to have a real white in the green box, and the background on the daum one looks pretty horrid to me.

I'm not against taking this on both l10n-central and 1.9.2, but I don't think that it's worth the hassle on 1.9.1., let alone 1.9.0.
Attachment #463816 - Flags: review-
Attachment #463816 - Flags: approval1.9.0.next?
Attachment #463816 - Flags: approval1.9.0.next-
(Assignee)

Comment 3

7 years ago
Created attachment 464364 [details] [diff] [review]
Changing favicon of Daum and Naver for Firefox 3.6.x

I revised Daum's icon and want to fix it in Firefox 3.6.9.
Attachment #464364 - Flags: review?(l10n)
(Assignee)

Updated

7 years ago
blocking1.9.2: --- → ?

Comment 4

7 years ago
This is not a blocker. If approved patches are ready before code freeze, feel free to ask for branch landing approval.
blocking1.9.2: ? → -

Comment 5

7 years ago
Why did this land without review in http://hg.mozilla.org/l10n-central/ko/rev/b23a0aa233ed?

PS: I still think the Naver logo is wrong with being transparent inside.

Comment 6

7 years ago
Hrm. interesting, the patch that landed has different icons than the one attached to this bug?
Created attachment 466269 [details]
Screenshot of Daum's icon

Looks like the Daum's icon that landed is a bit different from the one in favicon.ico. The "D" is less rounded and doesn't have the shadow. Channy, did you change that on purpose?
(Assignee)

Comment 8

7 years ago
Oops, It pushed my another working copy (including hg commit of this bug) by manual script with my real working copy. I'll regress and attach another patch soon. Sorry.
(Assignee)

Comment 9

7 years ago
Created attachment 466271 [details]
Final patch by ico file for Daum and Naver icons

I resized ico to png file format because of file size (over 5kb). But, there are some differences on resizing. 

So I used primary icon files despite of large size. Please check again!
Attachment #463816 - Attachment is obsolete: true
Attachment #464364 - Attachment is obsolete: true
Attachment #466271 - Flags: review?(l10n)
Attachment #464364 - Flags: review?(l10n)
(Assignee)

Comment 10

7 years ago
Created attachment 466272 [details] [diff] [review]
Final patch by ico file for Daum and Naver icons
Attachment #466271 - Attachment is obsolete: true
Attachment #466272 - Flags: review?(l10n)
Attachment #466271 - Flags: review?(l10n)
Comment on attachment 466272 [details] [diff] [review]
Final patch by ico file for Daum and Naver icons

r=me. Please land this patch on 1.9.2 and central and sign off for 3.6.x and 4.0 beta. Thanks, Channy!
Attachment #466272 - Flags: review?(l10n) → review+
(Assignee)

Comment 12

7 years ago
fixed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.