Closed Bug 585374 Opened 9 years ago Closed 9 years ago

Add RTL support to about:about

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b5

People

(Reporter: tomer, Assigned: philor)

References

Details

(Keywords: rtl)

Attachments

(2 files)

Attached image Current result
bug 220253 introduced an about:about page. Sadly, there is currently no right-to-left support on the page. In order to make it theme-independent, we can't just add it to the linked stylesheet, so I suggest doing the same we did for other about pages - linking to chrome://global/locale/global.dtd, and adding dir="&locale.dir;" to <body>.

I have tried to patch the file, but it seems that the file is broken due to its license header. I'll investigate it at the morning.
blocking2.0: --- → ?
Attached patch FixSplinter Review
The license is preprocessed out, so you can't do things like copy from the source and paste into the jar in a build, you have to either edit the already preprocessed file or actually build with the unpreprocessed one to get it stripped.

For reasons I'm not willing to understand (since they'd involve deep-tree-walker), the Force RTL extension won't flip about:about, so you have to actually change locale.dir in global.dtd to test the patch.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #463853 - Flags: review?(gavin.sharp)
blocking2.0: ? → final+
Attachment #463853 - Flags: review?(gavin.sharp) → review+
blocking2.0: final+ → ---
http://hg.mozilla.org/mozilla-central/rev/76ab4a4d111c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
You need to log in before you can comment on or make changes to this bug.