585500 - Can't load utilityOverlay.js into placesOverlay.xul

Status: RESOLVED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect)

Description

[Robert Kaiser]

Ideally, we should declare TAB_DROP_TYPE in utilityOverlay.js and make both places (already using it) and tabbrowser (still to do) use this var from this one definition.

Firefox loads utilityOverlay.js in their placesOverlay.xul, see http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/places/content/placesOverlay.xul#52

When we do that on our side, we get this in the Error Console:

Error: redeclaration of const kProxyManual
Source File: chrome://communicator/content/utilityOverlay.js
Line: 56

That const is not defined anywhere else.

If we don't include utilityOverlay.js there, we get this one:

Error: TAB_DROP_TYPE is not defined
Source File: chrome://communicator/content/places/controller.js
Line: 1589

I'm papering over the latter with reintroducing the additional declaration I had in there locally before I removed it due to bug 580656 comment #10, but we should see how we can fix this properly.

Comment 1

[Robert Kaiser]

Pushed the paper-over declaration as http://hg.mozilla.org/comm-central/rev/a5389bc6ee48 (fixing a few test failures and drag&drop of bookmarks) with rs=Callek over IRC.

Comment 2

[[e-mail]]

Something is probably loading controller.js before utilityOverlay.js so adding another load of utilityOverlay.js just causes the redeclaration.

Comment 3

[Phoenix]

I see TAB_DROP_TYPE declared in http://mxr.mozilla.org/comm-central/source/suite/common/utilityOverlay.js#37 and utilityOverlay.js loaded in http://mxr.mozilla.org/comm-central/source/suite/common/utilityOverlay.xul#26, is this bug still actual?

Comment 4

[Phoenix]

Resolved per whiteboard