585692 - reuse code in js_ReportIsNotFunction to produce precise errors from natives

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

(Follow-up to bug 581900)
As described in bug 581900, natives can't assume they are called directly from the interpreter or that they know the sp-offset of their input values.  js_ReportIsNotFunction avoids using JSDVG_SEARCH_STACK by intelligently searching the stack for the right Value*.  This could be factored into DVG and reused by, e.g., obj_getPrototypeOf.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: wip

Just throwing it out there so we can think about if this is useful.

I think we should be able to replace most of the stack search code in js_DecompileValueGenerator, but for now I only try the new method and fall back to the new one.

This patch gives us better (for some definition of better, that still needs to evaluated) error reporting for free, when DecompileValueGenerator or ReportValueError is used.

Comment 2

[Tom S. (please needinfo tschuster)]

Yaay -1 assigned bug for free, somebody fixed this stuff.