[PP]Toolbar example has no toolbar buttons or crashes

VERIFIED FIXED in M6

Status

()

Core
XUL
P2
normal
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: Chris McAfee, Assigned: Eric Vaughan)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
Linux, current build of apprunner.
Debug|XPToolkit|Toolbar crashes.

#0  0x40bc46a1 in __kill ()
#1  0x40bc44cf in raise (sig=6) at ../sysdeps/posix/raise.c:27
#2  0x40bc56df in abort () at ../sysdeps/generic/abort.c:83
#3  0x408d6292 in PR_Abort () at prlog.c:461
#4  0x4003e486 in nsDebug::Abort (aFile=0x40684a60 "nsFormControlHelper.cpp",
    aLine=267) at nsDebug.cpp:93
#5  0x4003e4ea in nsDebug::Break (aFile=0x40684a60 "nsFormControlHelper.cpp",
    aLine=267) at nsDebug.cpp:108
#6  0x4003e62d in nsDebug::Assertion (
    aStr=0x40684a8b "form control's computed width is <= 0",
    aExpr=0x40684a78 "aCSSSize.width > 0",
    aFile=0x40684a60 "nsFormControlHelper.cpp", aLine=267) at nsDebug.cpp:140
#7  0x40557a4b in nsFormControlHelper::CalculateSize (aPresContext=0x8332368,
    aRendContext=0x8455820, aFrame=0x8453718, aCSSSize=@0xbfffb7b4,
    aSpec=@0xbfffb770, aDesiredSize=@0xbfffb7ac, aMinSize=@0xbfffb7a4,
    aWidthExplicit=@0xbfffb7a0, aHeightExplicit=@0xbfffb79c,
    aRowHeight=@0xbfffb798) at nsFormControlHelper.cpp:267
#8  0x4056a5a3 in nsTextControlFrame::GetDesiredSize (this=0x84536e8,
    aPresContext=0x8332368, aReflowState=@0xbfffb8f4,
    aDesiredLayoutSize=@0xbfffbb10, aDesiredWidgetSize=@0x8453724)
    at nsTextControlFrame.cpp:261
#9  0x4056467f in nsFormControlFrame::Reflow (this=0x84536e8,
    aPresContext=@0x8332368, aDesiredSize=@0xbfffbb10,
    aReflowState=@0xbfffb8f4, aStatus=@0xbfffc6c0)
    at nsFormControlFrame.cpp:248
#10 0x405f793c in nsBoxFrame::FlowChildAt (this=0x8451e20,
    childFrame=0x84536e8, aPresContext=@0x8332368, desiredSize=@0xbfffbb10,
    aReflowState=@0xbfffbba4, aStatus=@0xbfffc6c0, size=@0xbfffbab8,
    incrementalChild=@0xbfffbb40) at nsBoxFrame.cpp:258
#11 0x405f8f95 in nsBoxFrame::Reflow (this=0x8451e20,
    aPresContext=@0x8332368, aDesiredSize=@0xbfffbdc0,
    aReflowState=@0xbfffbba4, aStatus=@0xbfffc6c0) at nsBoxFrame.cpp:642
#12 0x405f793c in nsBoxFrame::FlowChildAt (this=0x844dc10,
    childFrame=0x8451e20, aPresContext=@0x8332368, desiredSize=@0xbfffbdc0,
    aReflowState=@0xbfffbe78, aStatus=@0xbfffc6c0, size=@0xbfffbd68,
    incrementalChild=@0xbfffbdf0) at nsBoxFrame.cpp:258

...

#29 0x404bd385 in ViewportFrame::Reflow (this=0x84487f8,
    aPresContext=@0x8332368, aDesiredSize=@0xbfffebec,
    aReflowState=@0xbfffeb44, aStatus=@0xbfffebe8) at nsViewportFrame.cpp:432
#30 0x404ac937 in PresShell::InitialReflow (this=0x82fe490, aWidth=7140,
    aHeight=3912) at nsPresShell.cpp:891
#31 0x40d85d02 in XULDocumentImpl::StartLayout (this=0x84312e0)
    at nsXULDocument.cpp:3486
#32 0x40d8051a in XULDocumentImpl::EndLoad (this=0x84312e0)
    at nsXULDocument.cpp:1665
#33 0x40d9fd06 in XULContentSinkImpl::DidBuildModel (this=0x8429110,
    aQualityLevel=1) at nsXULContentSink.cpp:501
#34 0x406ff127 in CWellFormedDTD::DidBuildModel (this=0x8433240,
    anErrorCode=0, aNotifySink=1, aParser=0x8429168, aSink=0x8429110)
    at nsWellFormedDTD.cpp:289
#35 0x406f7666 in nsParser::DidBuildModel (this=0x8429168, anErrorCode=0)
    at nsParser.cpp:463
#36 0x406f8126 in nsParser::ResumeParse (this=0x8429168, aDefaultDTD=0x0)
    at nsParser.cpp:802
#37 0x406f7761 in nsParser::EnableParser (this=0x8429168, aState=1)
    at nsParser.cpp:540
#38 0x40da0826 in XULContentSinkImpl::DoneLoadingStyle (aLoader=0x83073c8,
    aData=@0x83073e8, aRef=0x842c418, aStatus=0) at nsXULContentSink.cpp:777
#39 0x4028ff4f in nsUnicharStreamLoader::OnStopBinding (this=0x83073c8,
    aURL=0x83072e8, aStatus=0, aMsg=0xbfffee7c) at nsNetStreamLoader.cpp:156
#40 0x402b4efe in nsDocumentBindInfo::OnStopBinding (this=0x8426af8,
    aURL=0x83072e8, aStatus=0, aMsg=0xbfffee7c) at nsDocLoader.cpp:2095
#41 0x4029318f in stub_complete (stream=0x83047f8) at nsStubContext.cpp:765
#42 0x401af64b in net_ProcessFile (cur_entry=0x8307740) at mkfile.c:1360
#43 0x40261f17 in NET_ProcessNet (ready_fd=0x0, fd_type=1) at mkgeturl.c:3355
#44 0x40269df9 in NET_PollSockets () at mkselect.c:298
#45 0x4028cb02 in nsNetlibService::NetPollSocketsCallback (aTimer=0x82fe7c0,
    aClosure=0x809f730) at nsNetService.cpp:1263
#46 0x40178de9 in TimerImpl::FireTimeout (this=0x82fe7c0) at nsTimer.cpp:73
#47 0x401792d2 in nsTimerExpired (aCallData=0x82fe7c0) at nsTimer.cpp:189
#48 0x40a74a60 in g_timeout_dispatch (source_data=0x82623a8,
    current_time=0xbffff32c, user_data=0x82fe7c0) at gmain.c:1144
#49 0x40a73d53 in g_main_dispatch (current_time=0xbffff32c) at gmain.c:644
#50 0x40a742df in g_main_iterate (block=1, dispatch=1) at gmain.c:851
#51 0x40a74461 in g_main_run (loop=0x80f7d98) at gmain.c:909
#52 0x409a15f7 in gtk_main () at gtkmain.c:501
#53 0x400af240 in nsAppShell::Run (this=0x80df778) at nsAppShell.cpp:203
#54 0x4001e0a9 in nsAppShellService::Run (this=0x80785a8)
    at nsAppShellService.cpp:186
#55 0x804b874 in main (argc=1, argv=0xbffff4a4) at nsAppRunner.cpp:447

Updated

19 years ago
Assignee: pinkerton → evaughan
Priority: P3 → P2

Comment 1

19 years ago
reassigning to evaughan for triage, since it looks like a layout problem,
possibly in text controls?

Updated

19 years ago
Summary: Toolbar example crashes → [PP]Toolbar example crashes

Comment 2

19 years ago
Putting on [PP] radar.
(Reporter)

Comment 3

19 years ago
This is XUL bit rot.
I fixed the crash, now the toolbar buttons are showing
up blank.  I am guessing we need a separate css file to
specify the button images?
(Reporter)

Updated

19 years ago
Summary: [PP]Toolbar example crashes → [PP]Toolbar example has no toolbar buttons
(Reporter)

Updated

19 years ago
Target Milestone: M6
(Reporter)

Comment 4

19 years ago
We need to fix this, M6.
(Reporter)

Updated

19 years ago
Summary: [PP]Toolbar example has no toolbar buttons → [PP]Toolbar example has no toolbar buttons or crashes
(Reporter)

Comment 5

19 years ago
This now crashes on Linux:
#0  0x40834227 in main_arena ()
#1  0x402c40ae in nsDocumentBindInfo::OnStopBinding (this=0x850e018,
aURL=0x8478be8,
    aStatus=2152398849, aMsg=0xbfffe41c) at nsDocLoader.cpp:1536
#2  0x402a34a3 in bam_exit_routine (URL_s=0x82d8d48, status=-215,
window_id=0x851f7c0)
    at nsNetService.cpp:1453
#3  0x402749c6 in net_CallExitRoutine (
    exit_routine=0x402a3398 <bam_exit_routine(URL_Struct_ *, int, MWContext_
*)>,
    URL_s=0x82d8d48, status=-215, format_out=38, window_id=0x851f7c0) at
mkgeturl.c:1142
#4  0x4027778d in NET_GetURL (URL_s=0x82d8d48, output_format=102,
window_id=0x851f7c0,
    exit_routine=0x402a3398 <bam_exit_routine(URL_Struct_ *, int, MWContext_
*)>)
    at mkgeturl.c:3118
#5  0x402a1835 in nsNetlibService::OpenStream (this=0x8084550, aUrl=0x8478be8,
    aConsumer=0x850e018) at nsNetService.cpp:480
#6  0x402c3939 in nsDocumentBindInfo::Bind (this=0x850e018, aURL=0x8478be8,
aListener=0x82d93bc)
    at nsDocLoader.cpp:1263
#7  0x402c2781 in nsDocLoaderImpl::OpenStream (this=0x82ceef0, aUrl=0x8478be8,
    aConsumer=0x82d93bc) at nsDocLoader.cpp:744
#8  0x402a2fe9 in NS_OpenURL (aURL=0x8478be8, aConsumer=0x82d93bc) at
nsNetService.cpp:1206
#9  0x402a644d in nsUnicharStreamLoader::nsUnicharStreamLoader (this=0x82d93b8,
aURL=0x8478be8,
    aFunc=0x40af91b4
<XULContentSinkImpl::DoneLoadingStyle(nsIUnicharStreamLoader *, nsString &, vo
id *, unsigned int)>, aRef=0x82d8cd8) at nsNetStreamLoader.cpp:68
#10 0x402a68e2 in NS_NewUnicharStreamLoader (aInstancePtrResult=0xbfffea8c,
aURL=0x8478be8,
    aFunc=0x40af91b4
<XULContentSinkImpl::DoneLoadingStyle(nsIUnicharStreamLoader *, nsString &, vo
id *, unsigned int)>, aRef=0x82d8cd8) at nsNetStreamLoader.cpp:212
#11 0x40af9b58 in XULContentSinkImpl::AddProcessingInstruction (this=0x85b8548,
aNode=@0xbfffec64)
    at nsXULContentSink.cpp:877
#12 0x4030817f in CWellFormedDTD::HandleToken (this=0x85aa2e0, aToken=0x8142ab8,
    aParser=0x85bd5f0) at nsWellFormedDTD.cpp:472
#13 0x40307d14 in CWellFormedDTD::BuildModel (this=0x85aa2e0, aParser=0x85bd5f0,
    aTokenizer=0x85ab410, anObserver=0x0, aSink=0x85b8548) at
nsWellFormedDTD.cpp:254
#14 0x40300ed4 in nsParser::BuildModel (this=0x85bd5f0) at nsParser.cpp:837
#15 0x40300db0 in nsParser::ResumeParse (this=0x85bd5f0, aDefaultDTD=0x0) at
nsParser.cpp:785
#16 0x40300799 in nsParser::EnableParser (this=0x85bd5f0, aState=1) at
nsParser.cpp:582
#17 0x40af92b2 in XULContentSinkImpl::DoneLoadingStyle (aLoader=0x851fb78,
aData=@0x851fb98,
    aRef=0x840ab90, aStatus=0) at nsXULContentSink.cpp:779
#18 0x402a6763 in nsUnicharStreamLoader::OnStopBinding (this=0x851fb78,
aURL=0x851faa0,
    aStatus=0, aMsg=0xbfffee78) at nsNetStreamLoader.cpp:156
#19 0x402c4056 in nsDocumentBindInfo::OnStopBinding (this=0x85aafe0,
aURL=0x851faa0, aStatus=0,
    aMsg=0xbfffee78) at nsDocLoader.cpp:1523
#20 0x402a9bf7 in stub_complete (stream=0x83e2a30) at nsStubContext.cpp:771
#21 0x401c464b in net_ProcessFile (cur_entry=0x851fec0) at mkfile.c:1360
#22 0x40277f17 in NET_ProcessNet (ready_fd=0x0, fd_type=1) at mkgeturl.c:3355
#23 0x4027fdf9 in NET_PollSockets () at mkselect.c:298
#24 0x402a324a in nsNetlibService::NetPollSocketsCallback (aTimer=0x85abc78,
aClosure=0x8084550)
    at nsNetService.cpp:1270
#25 0x4018de00 in TimerImpl::FireTimeout (this=0x85abc78) at nsTimer.cpp:77
#26 0x4018e2ea in nsTimerExpired (aCallData=0x85abc78) at nsTimer.cpp:193
#27 0x4066beb0 in g_timeout_dispatch (source_data=0x851ffd0,
current_time=0xbffff328,
    user_data=0x85abc78) at gmain.c:1147
#28 0x4066b1a3 in g_main_dispatch (current_time=0xbffff328) at gmain.c:647
#29 0x4066b72f in g_main_iterate (block=1, dispatch=1) at gmain.c:854
#30 0x4066b8b1 in g_main_run (loop=0x80f0a58) at gmain.c:912
#31 0x40596caf in gtk_main () at gtkmain.c:510
#32 0x400c3bdd in nsAppShell::Run (this=0x806cc78) at nsAppShell.cpp:198
#33 0x40022f5d in nsAppShellService::Run (this=0x8077768) at
nsAppShellService.cpp:401
#34 0x804bbb8 in main (argc=1, argv=0xbffff4a4) at nsAppRunner.cpp:482
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
eric, what was the fix??
(Reporter)

Comment 7

19 years ago
cvslog webshell/tests/viewer/samples/toolbarTest1.xul
i looked at the diff, but that doesn't say much. A missing spring? Was that it?
Any code changes?
(Assignee)

Comment 9

19 years ago
Something was wrong with the way to was setting up the xul namespace at the
beginning of the file. I copied the setup from another newer XUL file and it
fixed the problem.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 10

19 years ago
verified on

     1999-05-25-10 RedHat Linux 5.2 kernel 2.2.7
     1999-05-25-08 WinNT 4.0 sp4
     1999-05-24-17 MacOS 8.51
You need to log in before you can comment on or make changes to this bug.