585713 - Suite part of |Bug 552023 - Kill Places partitioned temp tables|

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Justin Wood (:Callek)]

see Bug 552023 and http://hg.mozilla.org/mozilla-central/rev/b1e658a332218266abe0b04eb9b877e5eba96e42

Comment 1

[Marco Bonardo [:mak]]

btw, we are about to backout for a Ts regression.

Comment 2

[Justin Wood (:Callek)]

:mak, is Bug 552023 still on the table for Gecko 2.0, its kind of my required tracker for this bug, and I want to *try* and plan resources for this if its needed.

Comment 3

[Marco Bonardo [:mak]]

(In reply to comment #2)
> :mak, is Bug 552023 still on the table for Gecko 2.0, its kind of my required
> tracker for this bug, and I want to *try* and plan resources for this if its
> needed.

we have 2 major Talos regressions caused by that (Win Tp4 and Lin Ts), Shawn is looking at them, but we won't be able to push the patches till we figure them out. So actually I can't tell you when they'll be ready, they're on the table and actively investigated.

Comment 4

[Justin Wood (:Callek)]

(In reply to comment #3)
> they're on the table and actively investigated.

Thats all i needed to know. Was more a "did we scrap this from the 2.0 plate due to risk, or is it still planned to land IF we can figure out the regressions"

Comment 5

[Serge Gautherie (:sgautherie)]

FF part re-landed: bug 552023 comment 89.

Comment 6

[Justin Wood (:Callek)]

(In reply to comment #5)
> FF part re-landed: bug 552023 comment 89.

Yep, and I'm holding off on this until I am sure it sticks.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just copy (the relevant part of) it [Checked in: See comment 10]

Comment 8

[Serge Gautherie (:sgautherie)]

This should also fix:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1294747530.1294762025.6867.gz&fulltext=1
WINNT 5.2 comm-central-trunk nightly on 2011/01/11 04:05:30
{
make package-compare
...
-bin/components/nsPlacesDBFlush.js
}

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 502780 [details] [diff] [review]
(Av1) Just copy (the relevant part of) it
[Checked in: See comment 10]

need to port http://hg.mozilla.org/mozilla-central/rev/c8d8af0fcc38 to http://mxr.mozilla.org/comm-central/source/suite/common/tests/browser/browser_markPageAsFollowedLink.js

Provided you fix that at the same time, r=me

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 502780 [details] [diff] [review]
(Av1) Just copy (the relevant part of) it
[Checked in: See comment 10]

http://hg.mozilla.org/comm-central/rev/21421642db18
(Oh, I forget to include r=you in the push comment :-()


(In reply to comment #9)
> need to port http://hg.mozilla.org/mozilla-central/rev/c8d8af0fcc38

Good catch! (changeset without bug number nor bug (552023) comment :-<)

And bug 610442 needed to be ported too ;->

Comment 11

[Serge Gautherie (:sgautherie)]

V.Fixed, per bug 620086 comment 3.