585723 - Make Mozmill-test testAccessLocationBar local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testAwesomeBar/testAccessLocationBar.js
Test-page: Any 3 pages from test-files/layout/mozilla*

Comment 1

[u279076]

Attachment: Patch v1 (default)

Comment 2

[Aaron Train [:aaronmt]]

Comment on attachment 464634 [details] [diff] [review]
Patch v1 (default)

> // Include necessary modules
> var RELATIVE_ROOT = '../../shared-modules';
> var MODULE_REQUIRES = ['PlacesAPI', 'ToolbarAPI'];

const
 
>+  // Second - Arrow down to open the autocomplete list, displaying
>+  // the most recent visit first, then arrow down again to the first entry, 
>+  // in this case mozilla.html
>   controller.keypress(locationBar.urlbar, "VK_DOWN", {});
>-  controller.sleep(gDelay);
>+  controller.sleep(DELAY);
I've been told to simply use 100 instead of DELAY

r-, otherwise patch looks good

Comment 3

[Aaron Train [:aaronmt]]

As well, 

+  // Open a few different sites to create a small history 
+  // NOTE: about:blank doesn't appear in history and clears the page 
+  //       for clean test arena
+  for each (page in LOCAL_TEST_PAGES) {
+    locationBar.loadURL(page);
     controller.waitForPageLoad();
   }

for each (var page in LOCAL_TEST_PAGES)

Comment 4

[u279076]

Attachment: Patch v2 (default)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 464961 [details] [diff] [review]
Patch v2 (default)

>+const LOCAL_TEST_PAGES = [
>+                          LOCAL_TEST_FOLDER + 'layout/mozilla.html',
>+                          LOCAL_TEST_FOLDER + 'layout/mozilla_projects.html',
>+                          LOCAL_TEST_FOLDER + 'layout/mozilla_mission.html',
>+                          'about:blank'

2 spaces as indent for arrays please.

>+  controller.waitForEval("subject.selectedIndex == 0", TIMEOUT, 100,
>+                         locationBar.autoCompleteResults);
>+  locationBar.contains("mozilla");

We should change the order of the pages. With moving up the projects page and check for 'projects' instead of 'mozilla' we have a reliable test.

>+  // Check that 'mozilla' is in the url bar
>+  locationBar.contains("mozilla");

Please also check for projects.

If the project page doesn't have an image, simply use another element for verification of a successful load.

Comment 6

[u279076]

Attachment: Patch v3 (default)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 465042 [details] [diff] [review]
Patch v3 (default)

>+const LOCAL_TEST_PAGES = [
>+                           LOCAL_TEST_FOLDER + 'layout/mozilla_projects.html',
>+                           LOCAL_TEST_FOLDER + 'layout/mozilla.html',
>+                           LOCAL_TEST_FOLDER + 'layout/mozilla_mission.html',
>+                           'about:blank'
>+                         ];

Please correct the indentation.

>   controller.keypress(locationBar.urlbar, "VK_DOWN", {});
>-  controller.sleep(gDelay);
>+  controller.sleep(100);
>   controller.keypress(locationBar.urlbar, "VK_DOWN", {});
>-  controller.sleep(gDelay);
>+  controller.sleep(100);
> 
>-  // checks that the first item in the drop down list is selected.
>-  controller.waitForEval("subject.selectedIndex == 0",
>-                         gTimeout, 100, locationBar.autoCompleteResults);
>-  locationBar.contains("getpersonas");
>+  // Check that the first item in the drop down list is selected
>+  controller.waitForEval("subject.selectedIndex == 0", TIMEOUT, 100,
>+                         locationBar.autoCompleteResults);
>+  locationBar.contains("projects");

Probably my fault from the last review but this should fail. We have to test for mission. Was a test-run successful?

>+  // Check that 'mozilla' is in the url bar
>+  locationBar.contains("projects");

nit: Please update both lines according to the comment above.

Comment 8

[u279076]

Attachment: Patch v4 (default)

Comment 9

[u279076]

> Probably my fault from the last review but this should fail. We have to test
> for mission. Was a test-run successful?

Patch v4 (attached) addresses your comments in comment 7.  Unfortunately, I cannot verify whether this completely passes due to the dependent failure.  Let's get the localization addressed first so we can resolve the failure.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Which dependent failure do you mean?

Comment 11

[u279076]

(In reply to comment #10)
> Which dependent failure do you mean?

It's the 1st bug marked as Dependent on this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=575986

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 465475 [details] [diff] [review]
Patch v4 (default)

>-  // Check that getpersonas is in the url bar
>-  locationBar.contains("getpersonas");
>+  // Check that 'mission' is in the url bar
>+  locationBar.contains("mission");
> }

Now with the move to the local page we should be able to compare the URL directly. There shouldn't be a need to check only parts of it. Can you please fix this?

Otherwise r=me (given that the patch has been tested and run successfully)

Comment 13

[u279076]

(In reply to comment #8)
> Created attachment 465475 [details] [diff] [review]
> Patch v4 (default)

Landed on default with comment 12 addressed:
http://hg.mozilla.org/qa/mozmill-tests/rev/8be37f99b646

Comment 14

[u279076]

Attachment: Backport patch [1.9.2]

Comment 15

[u279076]

(In reply to comment #14)
> Created attachment 478005 [details] [diff] [review]
> Backport patch

Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/56f6915532a4

Comment 16

[u279076]

Attachment: Backport patch [1.9.1]

Comment 17

[u279076]

(In reply to comment #16)
> Created attachment 478015 [details] [diff] [review]
> Backport patch [1.9.1]

Landed on mozilla1.9.1:
http://hg.mozilla.org/qa/mozmill-tests/rev/0a69eedf2cad

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.