585731 - Make Mozmill-test testVisibleItemsMax local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testAwesomeBar/testVisibleItemsMax.js
Test-page: Use all 8 pages from test-files/layout/mozilla*

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

cleanup + converts test to make use of local-data

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 469498 [details] [diff] [review]
Patch v1 - (default)

>+var setupModule = function()
> {

Brackets cleanup for all functions please.

>+  for each (var localPage in LOCAL_PAGES) {
>+    locationBar.loadURL(localPage);

Can you use page instead of localPage?

With the changes r=me.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - [nit fixes] - (default)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 474744 [details] [diff] [review]
Patch v1 - [nit fixes] - (default)

you can take over r+ once you add a new patch.

Comment 5

[u279076]

(In reply to comment #3)
> Created attachment 474744 [details] [diff] [review]
> Patch v1 - [nit fixes] - (default)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/d98cbaf03170 [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/1dc021ac02d2 [mozilla1.9.2]

Please provide a 1.9.1 patch.

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (1.9.1)

For whatever reason this was never in the 1.9.1 repository. This patch adds it. I tested running it solo and alongside the testAwesombar suite and it passes.

Comment 7

[u279076]

(In reply to comment #6)
> Created attachment 478065 [details] [diff] [review]
> Patch v1 - (1.9.1)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/6edb56e9ac5c [mozilla1.9.1]

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.