Closed Bug 585750 Opened 11 years ago Closed 11 years ago
JM: Fix PIC Resetting
PIC resetting is not well-tested, leading to problems when gczeal(2) is inserted by the fuzzer. One such testcase (bug 585540) revealed a problem with resetting that only segfaulted on x86_64 but was wrong on x86. There were two problems: - GetPropCompiler::reset() was attempting to patch the inline path's type guard jump, even if it didn't exist; - GetElemCompiler had no reset method, instead hijacking GetPropCompiler's, which used invalid values. The attached patch respects pic->hasTypeGuard() and implements GetElemCompiler::reset().
Attachment #464185 - Flags: review?(dvander)
11 years ago
Attachment #464185 - Flags: review?(dvander) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Good work. I was just working on the same thing, discovered via running trace-tests with gczeal on. This was most likely causing unpredictable Mochitest failures as well.
You need to log in before you can comment on or make changes to this bug.