585772 - Make Mozmill-test testPasswordSavedAndDeleted local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testPasswordManager/testPasswordSavedAndDeleted.js
Test-page: test-files/password_manager/login_form.html

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

cleanup + converts test to use local-data

Comment 2

[u279076]

Comment on attachment 466638 [details] [diff] [review]
Patch v1 - (default)

>+var setupModule = function() {
>   controller = mozmill.getBrowserController();
>   tabBrowser = new TabbedBrowsingAPI.tabBrowser(controller);
> 
>-  module.pm = Cc["@mozilla.org/login-manager;1"]
>+  pm = Cc["@mozilla.org/login-manager;1"]
>                  .getService(Ci.nsILoginManager);

Please fix the indentation on this (. at end of line and 2 space indent)

>+  var label = UtilsAPI.getProperty("chrome://passwordmgr/locale/passwordmgr.properties", 
>+                                   "notifyBarRememberButtonText");
>   var button = tabBrowser.getTabPanelElement(tabBrowser.selectedIndex,
>                                              '/{"value":"password-save"}/{"label":"' + label + '"}');

Please break the string into 2 lines on the /

> var confirmHandler = function(controller) {
>   controller.waitThenClick(new elementslib.Lookup(controller.window.document,
>+                           '/id("commonDialog")/anon({"anonid":"buttons"})' + 
>+                           '/{"dlgtype":"accept"}'), TIMEOUT);

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (default)

indentation fix

Comment 4

[u279076]

Comment on attachment 471500 [details] [diff] [review]
Patch v1.1 - (default)

>+  pm = Cc["@mozilla.org/login-manager;1"]
>+          .getService(Ci.nsILoginManager);

Please put . at the end of the first line and fix indentation

> var confirmHandler = function(controller) {
>   controller.waitThenClick(new elementslib.Lookup(controller.window.document,
>+                           '/id("commonDialog")' + 
>+                           '/anon({"anonid":"buttons"})' + 
>+                           '/{"dlgtype":"accept"}'), TIMEOUT);
> }

Please move Lookup to its own var

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Patch v1.2 - [nit fixes] - (default)

Comment 6

[u279076]

(In reply to comment #5)
> Created attachment 473521 [details] [diff] [review]
> Patch v1.2 - [nit fixes] - (default)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/91dea2a04d1c [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/f9558ab5e092 [mozilla1.9.2]
http://hg.mozilla.org/qa/mozmill-tests/rev/18730d072c04 [mozilla1.9.1]

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.