585782 - Make Mozmill-test testTabRestoration local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testPrivateBrowsing/testTabRestoration.js
Test-page: Use any 2 pages from test-files/layout/mozilla*

Comment 1

[u279076]

Attachment: Patch v1 (default)

Comment 2

[Aaron Train [:aaronmt]]

Comment on attachment 464993 [details] [diff] [review]
Patch v1 (default)

>+  for (var i=0; i<LOCAL_TEST_PAGES.length; i++) {
>+    var elem = new elementslib.ID(controller.tabs.getTab(i), LOCAL_TEST_PAGES[i].id);
>+    controller.waitForElement(elem, TIMEOUT);

>+  for (var i=0; i<LOCAL_TEST_PAGES.length; i++) {
>+    var elem = new elementslib.ID(controller.tabs.getTab(i), LOCAL_TEST_PAGES[i].id);
>+    controller.waitForElement(elem, TIMEOUT);

Nit: Space between your declaration and conditions in the for statement

Comment 3

[u279076]

Attachment: Patch v2 (default)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 465020 [details] [diff] [review]
Patch v2 (default)

>+const LOCAL_TEST_PAGES = [
>+                          {url: LOCAL_TEST_FOLDER + 'layout/mozilla_contribute.html',
>+                           id: 'localization'},
>+                          {url: LOCAL_TEST_FOLDER + 'layout/mozilla_community.html',
>+                           id: 'history'}
>+                         ];

2 blanks as indentation.

> var setupModule = function(module)
> {

Would be great if you can also move up the opening brackets for all functions.

>+  controller.assertJS("subject.tabs.length == " + (LOCAL_TEST_PAGES.length + 1),
>                       controller);

Please pass in both values as an object.

Comment 5

[u279076]

Attachment: Patch v3 (default)

Comment 6

[u279076]

> Created attachment 465052 [details] [diff] [review]
> Patch v3 (default)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/2a6f2e02c13d (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/dcda10b86230 (mozilla1.9.2)

Does not cleanly apply to mozilla1.9.1, patch forthcoming.

Comment 7

[u279076]

Attachment: Patch v3 (mozilla1.9.1)

Comment 8

[Aaron Train [:aaronmt]]

Comment on attachment 465470 [details] [diff] [review]
Patch v3 (mozilla1.9.1)

r+, looks good

Comment 9

[u279076]

> Created attachment 465470 [details] [diff] [review]
> Patch v3 (mozilla1.9.1)

Landed on mozilla1.9.1:
http://hg.mozilla.org/qa/mozmill-tests/rev/583bc6911cd5

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.