585784 - Make Mozmill-test testTabsDismissedOnStop local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testPrivateBrowsing/testTabsDismissedOnStop.js
Test-page: Use any 1 page from test-files/layout/mozilla*

Comment 1

[u279076]

Attachment: Patch v1 (default)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 464982 [details] [diff] [review]
Patch v1 (default)

>+const LOCAL_TEST_PAGES = [
>+                          {url: LOCAL_TEST_FOLDER + 'layout/mozilla.html', id: 'organization'},
>+                          {url: 'about:', id: 'aboutPageList'}
>+                         ];

Array declarations should indent with 2 spaces.

> var setupModule = function(module)
> {

Can you move up the opening bracket for all functions and remove module?

>+  for (var i=0; i<LOCAL_TEST_PAGES.length; i++) {

nit: Add spaces round those operators.

r=me with those comments addressed.

Comment 3

[u279076]

Attachment: Patch v2 (default)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 465038 [details] [diff] [review]
Patch v2 (default)

>+const LOCAL_TEST_PAGES = [
>+                           {url: LOCAL_TEST_FOLDER + 'layout/mozilla.html', id: 'organization'},
>+                           {url: 'about:', id: 'aboutPageList'}
>+                         ];

Still miss the 2 blank indentation change. Please fix that before the check-in.

Comment 5

[u279076]

Attachment: Patch v3

Comment 6

[u279076]

(In reply to comment #5)
> Created attachment 465069 [details] [diff] [review]
> Patch v3

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/7d5a11acfef4 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/ff0ccb2da1b0 (mozilla1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/8a7873bbfe8b (mozilla1.9.1)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.