585787 - Replace global compares with compartment compares in quickstubs once the latter are fast

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See comments in the patch for bug 585783.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Fix.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Why is the right thing cx->compartment and not obj->compartment() ?

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 485229 [details] [diff] [review]
Fix.

There's one more place that needs this change, new patch coming up.

Comment 4

[Andreas Gal :gal]

obj->compartment has to be equal to cx->compartment and cx->compartment is cheaper to read. We should assert this for extra safety.

Comment 5

[Johnny Stenback (:jst)]

Attachment: Fix, both places covered, and with assertions.

Comment 6

[Boris Zbarsky [:bzbarsky]]

The assertions went awol....

Andreas, thanks for explaining.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 485232 [details] [diff] [review]
Fix, both places covered, and with assertions.

Duh, forgot to qref, new patch coming up.

Comment 8

[Johnny Stenback (:jst)]

Attachment: Fix, both places covered, and with assertions for real this time.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Can we land this, please?  I'd really like to merge the patch for bug 590612 on top of this, instead of just conflicting with this change....

Comment 10

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/410c9f17f0fc

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Peter's patch merged to

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 490890 [details] [diff] [review]
Peter's patch merged to

Er... ignore this.  bzexport fail.