585790 - Make Mozmill-test testNewTab local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testTabbedBrowsing/testNewTab.js
Test-page: Use any 1 page from test-files/layout/mozilla*

Comment 1

[u279076]

Attachment: Patch v1 (default)

Comment 2

[Aaron Train [:aaronmt]]

Comment on attachment 464665 [details] [diff] [review]
Patch v1 (default)

> // Include necessary modules
> var RELATIVE_ROOT = '../../shared-modules';
> var MODULE_REQUIRES = ['TabbedBrowsingAPI', 'UtilsAPI'];
const 
>-const gDelay = 0;
>-const gTimeout = 5000;
>+const DELAY = 0;
>+const TIMEOUT = 5000;
I've been told to remove DELAY if the test does not make use of it.

>+//const LOCAL_TEST_FOLDER = collector.addHttpResource('../test-files/');
>+//const LOCAL_TEST_PAGE = LOCAL_TEST_FOLDER + 'layout/mozilla.html';
Test wont run if these are commented out


r-, the biggy is the above line which is commented out - otherwise the remainder of the patch looks good

Comment 3

[u279076]

Attachment: Patch v2 (default)

Comment 4

[u279076]

(In reply to comment #3)
> Created attachment 464959 [details] [diff] [review]
> Patch v2 (default)

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/022df0f082f0

Does not apply cleanly to mozilla1.9.2/1.9.1, followup patches forthcoming.

Comment 5

[u279076]

Attachment: Patch v2 (mozilla1.9.2)

Comment 6

[u279076]

Attachment: Patch v2 (mozilla1.9.1)

Comment 7

[u279076]

> Created attachment 465282 [details] [diff] [review]
> Patch v2 (mozilla1.9.2)

Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/8c95bcd1fcae

Comment 8

[u279076]

> Created attachment 465285 [details] [diff] [review]
> Patch v2 (mozilla1.9.1)

Landed on mozilla1.9.1:
http://hg.mozilla.org/qa/mozmill-tests/rev/b6cbbbd06ba1

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.