Closed
Bug 585792
Opened 14 years ago
Closed 14 years ago
Make Mozmill-test testAccessPageInfoDialog local
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u279076, Assigned: u279076)
References
Details
(Whiteboard: [litmus-data])
Attachments
(2 files, 1 obsolete file)
|
3.75 KB,
patch
|
aaronmt
:
review+
whimboo
:
review+
|
Details | Diff | Splinter Review |
|
3.80 KB,
patch
|
aaronmt
:
review+
whimboo
:
review+
|
Details | Diff | Splinter Review |
Module: testTechnicalTools/testAccessPageInfoDialog.js
Test-page: Use any 1 page from test-files/layout/mozilla*
Attachment #464658 -
Flags: review?(aaron.train)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 464658 [details] [diff] [review]
Patch v1 (default)
> // Include necessary modules
> var RELATIVE_ROOT = '../../shared-modules';
> var MODULE_REQUIRES = ['UtilsAPI'];
const
>-const gDelay = 0;
>-const gTimeout = 5000;
>+const DELAY = 0;
>+const TIMEOUT = 5000;
I've been told if we're not using a gDelay in the test, it should be removed.
r-, otherwise patch looks good
Attachment #464658 -
Flags: review?(aaron.train) → review-
Attachment #464658 -
Attachment is obsolete: true
Attachment #464955 -
Flags: review?(aaron.train)
|
|
||
Updated•14 years ago
|
Attachment #464955 -
Flags: review?(aaron.train) → review+
Attachment #464955 -
Flags: review?(hskupin)
|
||
Updated•14 years ago
|
Attachment #464955 -
Flags: review?(hskupin) → review+
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76261d1d5d14
Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/e48365a97df0 (mozilla1.9.2)
Does not apply cleanly to mozilla1.9.1, patch forthcoming.
Attachment #465067 -
Flags: review?(aaron.train)
|
|
||
Updated•14 years ago
|
Attachment #465067 -
Flags: review?(aaron.train) → review+
Attachment #465067 -
Flags: review?(hskupin)
|
|
||
Updated•14 years ago
|
Attachment #465067 -
Flags: review?(hskupin) → review+
> Created attachment 465067 [details] [diff] [review]
> Patch v1 (mozilla1.9.1)
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/46a3022ca399
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•