585792 - Make Mozmill-test testAccessPageInfoDialog local

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

Module: testTechnicalTools/testAccessPageInfoDialog.js
Test-page: Use any 1 page from test-files/layout/mozilla*

Comment 1

[u279076]

Attachment: Patch v1 (default)

Comment 2

[Aaron Train [:aaronmt]]

Comment on attachment 464658 [details] [diff] [review]
Patch v1 (default)

> // Include necessary modules
> var RELATIVE_ROOT = '../../shared-modules';
> var MODULE_REQUIRES = ['UtilsAPI'];
const
>-const gDelay = 0;
>-const gTimeout = 5000;
>+const DELAY = 0;
>+const TIMEOUT = 5000;

I've been told if we're not using a gDelay in the test, it should be removed.

r-, otherwise patch looks good

Comment 3

[u279076]

Attachment: Patch v2 (default)

Comment 4

[u279076]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76261d1d5d14

Comment 5

[u279076]

Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/e48365a97df0 (mozilla1.9.2)

Does not apply cleanly to mozilla1.9.1, patch forthcoming.

Comment 6

[u279076]

Attachment: Patch v1 (mozilla1.9.1)

Comment 7

[u279076]

> Created attachment 465067 [details] [diff] [review]
> Patch v1 (mozilla1.9.1)

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/46a3022ca399

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.