585838 - Disable update checks in any tests running in the browser

Status: RESOLVED FIXED

Description

[Nick Thomas [:nthomas] (UTC+12)]

I happened to inspect a windows 7 mini doing a mochitest-chrome run and it had the software update dialog up, wanting to restart Minefield to apply the update. Seems like this could be source of focus errors for tests that run in the browser, eg reftest.

Could we disable the updater ? Eg at 
 http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#292

Comment 1

[Robert Strong [:rstrong] (use needinfo to contact me)]

There are a bunch of mochitest-chrome app update tests which is probably why you saw the UI. Also note that these tests have been very consistently passing and I highly doubt they would cause problems since the UI will only show when there is an update available which is extremely unlikely to happen on the tinderbox. Having said that I don't have a problem with disabling app update for test automation but I need to verify that the app update tests work properly with app update disabled just in case.

Comment 2

[Robert Strong [:rstrong] (use needinfo to contact me)]

Created attachment 464344 [details] [diff] [review]
patch

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Hmm. I think I was looking at test jobs which had been running for several days, so they would have gotten offered a more recent nightly at some point. And normally that wouldn't happen with dep builds more recent than the nightly.

Comment 4

[Dave Townsend [:mossop]]

Also a=me for landing

Comment 5

[Robert Strong [:rstrong] (use needinfo to contact me)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c727df97c28c