The default bug view has changed. See this FAQ.

Bookmark sync for Seamonkey can be enabled

RESOLVED FIXED in 1.5

Status

Cloud Services
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Igor Velkov, Assigned: Igor Velkov)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Nightly builds of seamonkey now have places subsystem, and can sync bookmarks.
Here http://hg.mozilla.org/services/fx-sync/file/66592025ea61/addon/AddonGlue.js#l66

should be added Svc.DefaultPrefs.set("autoconnectDelay", 30); as for other browsers, and "Bookmarks" should be added to engines list if places engine available.
(Assignee)

Comment 1

7 years ago
Kairo, how to check if places bookmarks available?

Comment 2

7 years ago
Hmm, good question. I guess checking for a version equal or greater then 2.1a3 is the cheap possibility, you could also check if PlacesUIUtils.jsm can be imported, but that might be large, as you are running from a JS component here, I'm not sure if we always have an open browser window, so checking for its object is probably bad, but I guess you could fetch nsSuiteGlue and check if it has a "ensurePlacesDefaultQueriesInitialized" member/method as that's a public one we added with this work.
(Assignee)

Comment 3

7 years ago
Maybe, possible to use something like check of presence of provider?
(Assignee)

Comment 4

7 years ago
Something like
var BmkPlaces = true;
try {
   var bms = Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
                getService(Ci.nsINavBookmarksService);
}
catch 
{
    BmkPlaces = false;
}

Comment 5

7 years ago
That will always come back true, as this is implemented in toolkit and present in 2.0.x as well.

But maybe we should just always display bookmarks sync and be able to enable it, and just ignore that the synced bookmarks don't show up in builds that don't support them?
(Assignee)

Comment 6

7 years ago
Created attachment 464468 [details] [diff] [review]
enable bookmark sync for seamonkey

Then just enable it.
And also fix delay issue like it done for firefox.
Attachment #464468 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #464468 - Flags: review? → review?(mconnor)
(Assignee)

Comment 7

7 years ago
Created attachment 466329 [details] [diff] [review]
enable bookmark sync for seamonkey and bump compat info
Attachment #464468 - Attachment is obsolete: true
Attachment #466329 - Flags: review?
Attachment #464468 - Flags: review?(mconnor)
(Assignee)

Updated

7 years ago
Attachment #466329 - Flags: review? → review?(mconnor)

Updated

7 years ago
Attachment #466329 - Flags: review?(mconnor) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

7 years ago
Created attachment 466400 [details] [diff] [review]
enable bookmark sync for seamonkey and bump compat info

corrected seamonkey compat version to fit AMO
Attachment #466329 - Attachment is obsolete: true
Attachment #466400 - Flags: review?(mconnor)

Updated

7 years ago
Attachment #466400 - Flags: review?(mconnor) → review+

Comment 9

7 years ago
Pushed as http://hg.mozilla.org/services/fx-sync/rev/b3d039eaad62 (after merging with the bug 567583 patch I pushed at the same time).
Assignee: nobody → mozdiav
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.5
Blocks: 590633
You need to log in before you can comment on or make changes to this bug.