Closed Bug 585845 Opened 14 years ago Closed 14 years ago

Bookmark sync for Seamonkey can be enabled

Categories

(Cloud Services :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iav, Assigned: iav)

References

Details

Attachments

(1 file, 2 obsolete files)

Nightly builds of seamonkey now have places subsystem, and can sync bookmarks.
Here http://hg.mozilla.org/services/fx-sync/file/66592025ea61/addon/AddonGlue.js#l66

should be added Svc.DefaultPrefs.set("autoconnectDelay", 30); as for other browsers, and "Bookmarks" should be added to engines list if places engine available.
Kairo, how to check if places bookmarks available?
Hmm, good question. I guess checking for a version equal or greater then 2.1a3 is the cheap possibility, you could also check if PlacesUIUtils.jsm can be imported, but that might be large, as you are running from a JS component here, I'm not sure if we always have an open browser window, so checking for its object is probably bad, but I guess you could fetch nsSuiteGlue and check if it has a "ensurePlacesDefaultQueriesInitialized" member/method as that's a public one we added with this work.
Maybe, possible to use something like check of presence of provider?
Something like
var BmkPlaces = true;
try {
   var bms = Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
                getService(Ci.nsINavBookmarksService);
}
catch 
{
    BmkPlaces = false;
}
That will always come back true, as this is implemented in toolkit and present in 2.0.x as well.

But maybe we should just always display bookmarks sync and be able to enable it, and just ignore that the synced bookmarks don't show up in builds that don't support them?
Then just enable it.
And also fix delay issue like it done for firefox.
Attachment #464468 - Flags: review?
Attachment #464468 - Flags: review? → review?(mconnor)
Attachment #464468 - Attachment is obsolete: true
Attachment #466329 - Flags: review?
Attachment #464468 - Flags: review?(mconnor)
Attachment #466329 - Flags: review? → review?(mconnor)
Attachment #466329 - Flags: review?(mconnor) → review+
Keywords: checkin-needed
corrected seamonkey compat version to fit AMO
Attachment #466329 - Attachment is obsolete: true
Attachment #466400 - Flags: review?(mconnor)
Attachment #466400 - Flags: review?(mconnor) → review+
Pushed as http://hg.mozilla.org/services/fx-sync/rev/b3d039eaad62 (after merging with the bug 567583 patch I pushed at the same time).
Assignee: nobody → mozdiav
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.