585860 - Allow building with MOZ_MEDIA and MOZ_WEBGL disabled

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Dave Townsend [:mossop]]

Both of these build configurations are broken right now.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Are you able to review this Vlad or do I need others?

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 464291 [details] [diff] [review]
patch rev 1

Actually, no -- this patch isn't right.  For webgl, without MOZ_WEBGL we need to just build the dummy stuff in the canvas dir; I have a patch for that that I'll get checked in at some point this week.

For MOZ_MEDIA, I'd assume your problem is the decoders and not the media elements themselves, but I don't know much about the media side of things.

Comment 3

[Dave Townsend [:mossop]]

I guess this is the wrong approach and apparently supporting disabling MOZ_MEDIA is not something people really want to see

Comment 4

[hhaamu]

So I'm not allowed to build a basic web browser?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

You're allowed to do whatever you like with your own build!

Comment 6

[hhaamu]

Yes, and I can implement MNG support with no effort at all. My point was, if the build system doesn't give an option for it, it will be difficult to patch it in.

Besides, I'm sure many linux distributions (e.g. livecds) are interested in a web browser with lower footprint.

Comment 7

[(not currently active) Ted Mielczarek]

None of our build options are likely to significantly impact footprint. I also think anyone shipping our browser probably wants one that can actually display all the kinds of content that people think it can.