Closed
Bug 585933
Opened 14 years ago
Closed 14 years ago
Only unknown elements should implement HTMLUnknownElement
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Keywords: html5)
Attachments
(1 file, 1 obsolete file)
|
12.77 KB,
patch
|
Details | Diff | Splinter Review |
Also, it doesn't make sense to let it inherit from nsHTMLSpanElement. Patch attached.
Attachment #464394 -
Flags: review?(Olli.Pettay)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 464394 [details] [diff] [review]
Patch v1
I think we should do this, but Jonas should review this too, since he
actually removed nsHTMLUnknownElement in Bug 236873 (though that patch
left a bug in QI implementation: unknown element can be Qied to spanelement).
Attachment #464394 -
Flags: review?(jonas)
Attachment #464394 -
Flags: review?(Olli.Pettay)
Attachment #464394 -
Flags: review+
Comment on attachment 464394 [details] [diff] [review]
Patch v1
Looks good, you should write tests though.
Attachment #464394 -
Flags: review?(jonas) → review+
|
Assignee | |
Comment 3•14 years ago
|
||
Adding to test_bug389797.html gets me better coverage than writing up another test, I think.
Oh, sorry, missed that you had. Carry on then. As you were.
|
|
Assignee | |
Comment 5•14 years ago
|
||
The hunk is well hidden :)
I'll try to get this landed after braching.
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #464394 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•