586006 - Import CSS+graphics for mobile.SUMO modules

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Paul Craciunoiu [:paulc]]

Targeting for 2.2.3, the mobile site merging with desktop (which doesn't exist at the moment).

We'll need a mobile home page for that.

Comment 1

[Verdi [:verdi] Best to slack me]

Attachment: Mobile landing page mockup

Comment 2

[Verdi [:verdi] Best to slack me]

Hi Paul, I attached a mockup for the page. The idea is for it be very similar to the existing page with the exception of the search box. We'll want to move the desktop support and fx home sidebar modules over and use them along with the sumo module. Let me know if you have questions.

Comment 3

[David Tenser [:djst]]

To clarify, this bug should be about importing the css and graphics used for the two modules "Firefox Desktop Support" and "Firefox Home", since those are only available on the mobile.s.m.c site right now.

The hiding of the search box can be done through inline (wiki) CSS, so we don't need webdev help for that part.

Comment 4

[Verdi [:verdi] Best to slack me]

If we have to make a new template shouldn't we put everything we need in the template and not do any inline css? The way I understand it, if we do inline css then only admins can edit the page so localization will have to happen by people emailing me strings. We can still do that if we have to of course.

Comment 5

[David Tenser [:djst]]

I guess I should have asked you, Paul, how much work it would be to create the template to hide the search box instead of forcing us to hide it manually.

Cheng, what's the CSS used to hide the search box?

Comment 6

[Verdi [:verdi] Best to slack me]

CSS to hide the search box just .searchlogo {display: none;}

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: new images, extract to webroot/styles/mozmsmobile

Comment 8

[Paul Craciunoiu [:paulc]]

Attachment: v1, adds a new theme, mozmsmobile

To set things up:
* apply this patch
** fix symlinks (probably optional unless you plan to commit)
* create a new wiki page
* assign it the mozmsmobile theme (in tiki-theme_control_objects.php)
* create the sidebar modules from mobile (in tiki-admin_modules.php)
* assign them to the mozmsmobile theme

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: demo

FYI, this is what I see.

Comment 10

[Verdi [:verdi] Best to slack me]

Paul, is that a screenshot of the new theme that you made? If so, that looks great to me.

Comment 11

[Paul Craciunoiu [:paulc]]

(In reply to comment #10)
> Paul, is that a screenshot of the new theme that you made?
Yep.

Comment 12

[James Socol [:jsocol, :james]]

Comment on attachment 468850 [details] [diff] [review]
v1, adds a new theme, mozmsmobile

Mostly fine but the sidebar on mozmsmobile seems to be pushed too far left. Maybe I'm doing something wrong, though?

Comment 13

[Paul Craciunoiu [:paulc]]

(In reply to comment #12)
> Mostly fine but the sidebar on mozmsmobile seems to be pushed too far left.
> Maybe I'm doing something wrong, though?
Does it look like in the screenshot I posted?
Also, by sidebar, you mean not the side menu, but the 3 blocks underneath, right?
It looks just like the current page to me, without the search box
http://mobile.support.mozilla.com/en-US/kb/

I can make the modules be further to the right, if you want.

Comment 14

[Verdi [:verdi] Best to slack me]

It looks like the modules on support.mozilla.com are a little shifted to the left but not as much as on mobile.support.mozilla.com. It looks like the ones on this template could stand to be moved 20 pixels to the right.

Comment 15

[James Socol [:jsocol, :james]]

Comment on attachment 468850 [details] [diff] [review]
v1, adds a new theme, mozmsmobile

Ah yeah. My mistake. Good to go.

Comment 16

[Paul Craciunoiu [:paulc]]

Attachment: v1.1, moves modules sidebar 20px to the right

The only change is this:
webroot/styles/mozmsmobile.css
240c240
< +     margin-right: 50px;
---
> +     margin-right: 30px;

Comment 17

[James Socol [:jsocol, :james]]

Comment on attachment 469561 [details] [diff] [review]
v1.1, moves modules sidebar 20px to the right

WFM. (After flushing memcache, anyway.)

Comment 18

[Paul Craciunoiu [:paulc]]

r73145 on trunk.

Comment 19

[Rebecca Billings [:rbillings]]

Verified