If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Import CSS+graphics for mobile.SUMO modules

VERIFIED FIXED in 2.2.4

Status

support.mozilla.org
General
P1
normal
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: paulc, Assigned: paulc)

Tracking

unspecified
2.2.4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Targeting for 2.2.3, the mobile site merging with desktop (which doesn't exist at the moment).

We'll need a mobile home page for that.
(Assignee)

Updated

7 years ago
Target Milestone: --- → 2.2.3
Priority: P2 → P1

Updated

7 years ago
Depends on: 589852
Target Milestone: 2.2.3 → 2.2.4
Created attachment 468693 [details]
Mobile landing page mockup
Hi Paul, I attached a mockup for the page. The idea is for it be very similar to the existing page with the exception of the search box. We'll want to move the desktop support and fx home sidebar modules over and use them along with the sumo module. Let me know if you have questions.

Comment 3

7 years ago
To clarify, this bug should be about importing the css and graphics used for the two modules "Firefox Desktop Support" and "Firefox Home", since those are only available on the mobile.s.m.c site right now.

The hiding of the search box can be done through inline (wiki) CSS, so we don't need webdev help for that part.
Summary: Mobile home page on SUMO → Import CSS+graphics for mobile.SUMO modules
Whiteboard: See comment 3
If we have to make a new template shouldn't we put everything we need in the template and not do any inline css? The way I understand it, if we do inline css then only admins can edit the page so localization will have to happen by people emailing me strings. We can still do that if we have to of course.

Comment 5

7 years ago
I guess I should have asked you, Paul, how much work it would be to create the template to hide the search box instead of forcing us to hide it manually.

Cheng, what's the CSS used to hide the search box?
CSS to hide the search box just .searchlogo {display: none;}
(Assignee)

Comment 7

7 years ago
Created attachment 468849 [details]
new images, extract to webroot/styles/mozmsmobile
(Assignee)

Comment 8

7 years ago
Created attachment 468850 [details] [diff] [review]
v1, adds a new theme, mozmsmobile

To set things up:
* apply this patch
** fix symlinks (probably optional unless you plan to commit)
* create a new wiki page
* assign it the mozmsmobile theme (in tiki-theme_control_objects.php)
* create the sidebar modules from mobile (in tiki-admin_modules.php)
* assign them to the mozmsmobile theme
Attachment #468850 - Flags: review?(james)
(Assignee)

Comment 9

7 years ago
Created attachment 468886 [details]
demo

FYI, this is what I see.
Paul, is that a screenshot of the new theme that you made? If so, that looks great to me.
(Assignee)

Comment 11

7 years ago
(In reply to comment #10)
> Paul, is that a screenshot of the new theme that you made?
Yep.
Comment on attachment 468850 [details] [diff] [review]
v1, adds a new theme, mozmsmobile

Mostly fine but the sidebar on mozmsmobile seems to be pushed too far left. Maybe I'm doing something wrong, though?
(Assignee)

Comment 13

7 years ago
(In reply to comment #12)
> Mostly fine but the sidebar on mozmsmobile seems to be pushed too far left.
> Maybe I'm doing something wrong, though?
Does it look like in the screenshot I posted?
Also, by sidebar, you mean not the side menu, but the 3 blocks underneath, right?
It looks just like the current page to me, without the search box
http://mobile.support.mozilla.com/en-US/kb/

I can make the modules be further to the right, if you want.
It looks like the modules on support.mozilla.com are a little shifted to the left but not as much as on mobile.support.mozilla.com. It looks like the ones on this template could stand to be moved 20 pixels to the right.
Comment on attachment 468850 [details] [diff] [review]
v1, adds a new theme, mozmsmobile

Ah yeah. My mistake. Good to go.
Attachment #468850 - Flags: review?(james) → review+
(Assignee)

Updated

7 years ago
Whiteboard: See comment 3
(Assignee)

Comment 16

7 years ago
Created attachment 469561 [details] [diff] [review]
v1.1, moves modules sidebar 20px to the right

The only change is this:
webroot/styles/mozmsmobile.css
240c240
< +     margin-right: 50px;
---
> +     margin-right: 30px;
Attachment #468850 - Attachment is obsolete: true
Attachment #469561 - Flags: review?(james)
Comment on attachment 469561 [details] [diff] [review]
v1.1, moves modules sidebar 20px to the right

WFM. (After flushing memcache, anyway.)
Attachment #469561 - Flags: review?(james) → review+
(Assignee)

Comment 18

7 years ago
r73145 on trunk.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.