The default bug view has changed. See this FAQ.

Update JS_GetImplementationVersion for JS 1.8.5

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: bc, Assigned: Wesley W. Garland)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Update js version to 1.8.5 and date in JS_GetImplementationVersion in jsapi.cpp for the Firefox 4 release.

Do we want to support type="text/javascript;version=1.8.5" ?
(Assignee)

Updated

6 years ago
Blocks: 628723
(In reply to comment #0)
> Update js version to 1.8.5 and date in JS_GetImplementationVersion in jsapi.cpp
> for the Firefox 4 release.

I encourage Wes to take this bug and post the straightforward patch. I'll review. This is a zero-risk change (Gecko doesn't use the function) so I'll request approval to land it before FF4. If approval isn't granted, no big deal. You can apply the patch manually for the SM 1.8.5 source tarball, and we'll land it in the tracemonkey repo after FF4.

> Do we want to support type="text/javascript;version=1.8.5" ?

No.
(Assignee)

Comment 2

6 years ago
Created attachment 516596 [details] [diff] [review]
Trivial patch to tweak the version string

This affects only the jsapi.cpp function. No need to tweak jsversion.h, that was already done by jimb in October.

We should probably move toward having JS_GetImplementationVersion() and jsversion.h forcefully synchronized in the future.
Assignee: general → wes
Status: NEW → ASSIGNED
Attachment #516596 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #516596 - Flags: review? → review?(jorendorff)
Comment on attachment 516596 [details] [diff] [review]
Trivial patch to tweak the version string

r=me, and feel free to adjust that date to whatever we end up releasing.
Attachment #516596 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/tracemonkey/rev/9f71009b8f8b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
You need to log in before you can comment on or make changes to this bug.