Closed Bug 586016 Opened 11 years ago Closed 10 years ago

Update JS_GetImplementationVersion for JS 1.8.5

Categories

(Core :: JavaScript Engine, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bc, Assigned: wes)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Update js version to 1.8.5 and date in JS_GetImplementationVersion in jsapi.cpp for the Firefox 4 release.

Do we want to support type="text/javascript;version=1.8.5" ?
Blocks: js185src
(In reply to comment #0)
> Update js version to 1.8.5 and date in JS_GetImplementationVersion in jsapi.cpp
> for the Firefox 4 release.

I encourage Wes to take this bug and post the straightforward patch. I'll review. This is a zero-risk change (Gecko doesn't use the function) so I'll request approval to land it before FF4. If approval isn't granted, no big deal. You can apply the patch manually for the SM 1.8.5 source tarball, and we'll land it in the tracemonkey repo after FF4.

> Do we want to support type="text/javascript;version=1.8.5" ?

No.
This affects only the jsapi.cpp function. No need to tweak jsversion.h, that was already done by jimb in October.

We should probably move toward having JS_GetImplementationVersion() and jsversion.h forcefully synchronized in the future.
Assignee: general → wes
Status: NEW → ASSIGNED
Attachment #516596 - Flags: review?
Attachment #516596 - Flags: review? → review?(jorendorff)
Comment on attachment 516596 [details] [diff] [review]
Trivial patch to tweak the version string

r=me, and feel free to adjust that date to whatever we end up releasing.
Attachment #516596 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/tracemonkey/rev/9f71009b8f8b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
You need to log in before you can comment on or make changes to this bug.