Last Comment Bug 586050 - Double separator in menu of Bookmarks button in the Personal Toolbar
: Double separator in menu of Bookmarks button in the Personal Toolbar
Status: RESOLVED FIXED
: regression
Product: SeaMonkey
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: Trunk
: All All
: -- minor (vote)
: seamonkey2.1a3
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: SMPlacesBMarks
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-10 12:56 PDT by Jens Hatlak (:InvisibleSmiley)
Modified: 2010-08-11 09:06 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
remove duplicate separator [Checkin: comment 4] (496 bytes, patch)
2010-08-11 00:41 PDT, Jens Hatlak (:InvisibleSmiley)
neil: review+
neil: superreview+
kairo: approval‑seamonkey2.1a3+
Details | Diff | Review

Description Jens Hatlak (:InvisibleSmiley) 2010-08-10 12:56:55 PDT
After Places-based bookmarks landed, there's now a now consecutive separators below the "Subscribe to This Page" entry of the menu of the Bookmarks button in the Personal Toolbar.
Comment 1 Jens Hatlak (:InvisibleSmiley) 2010-08-11 00:41:54 PDT
Created attachment 464727 [details] [diff] [review]
remove duplicate separator [Checkin: comment 4]
Comment 2 Jens Hatlak (:InvisibleSmiley) 2010-08-11 04:52:06 PDT
KaiRo, can you check this in before making the a3 cut? I would have requested a3 approval but there is no flag, also it'd be some hours before I get home where I can check in myself. Should be very safe.
Comment 3 Robert Kaiser (not working on stability any more) 2010-08-11 06:18:41 PDT
We have open blockers, so there will be some time before the cut.

Thanks for noting the flag thing, though, will file a bug.
Comment 4 Jens Hatlak (:InvisibleSmiley) 2010-08-11 09:06:14 PDT
Comment on attachment 464727 [details] [diff] [review]
remove duplicate separator [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/3dcf1cce1b80

Note You need to log in before you can comment on or make changes to this bug.