Closed
Bug 586055
Opened 14 years ago
Closed 14 years ago
Eliminate users of browsers.item
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(blocking-seamonkey2.1 a3+)
VERIFIED
FIXED
seamonkey2.1a3
Tracking | Status | |
---|---|---|
blocking-seamonkey2.1 | --- | a3+ |
People
(Reporter: kairo, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
974 bytes,
patch
|
kairo
:
review+
kairo
:
approval-seamonkey2.1a3+
|
Details | Diff | Splinter Review |
In bug 585511, I eliminated browser.item, but we have a few callers left that should really die: robert@robert:/mnt/mozilla/hg/comm-central> grep -rin "browsers.item" suite/ suite/browser/navigator.js:552: for (var i = 0; browsers.item(i); i++) suite/common/bindings/notification.xml:50: this._activeBrowser = browsers.item(0); suite/common/bindings/notification.xml:53: if (browsers.item(i).docShell) { suite/common/bindings/notification.xml:54: this._activeBrowser = browsers.item(i);
Reporter | ||
Updated•14 years ago
|
blocking-seamonkey2.1: --- → ?
Comment 1•14 years ago
|
||
(In reply to comment #0) The notification.xml hits are false positives.
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #0) > suite/browser/navigator.js:552: for (var i = 0; browsers.item(i); i++) { 372 isTabContentWindow: function isTabContentWindow(aWindow) { 373 var browsers = gBrowser.browsers; 374 for (var i = 0; browsers.item(i); i++) 375 if (browsers[i].contentWindow == aWindow) 376 return true; 377 return false; 378 } } This code should be replaceable using "Array.some()", right?
Version: unspecified → Trunk
Reporter | ||
Comment 3•14 years ago
|
||
Serge, feel free to do a patch using this, I would have done it with something I better understand myself, but your idea might be better overall. ;-)
Version: Trunk → unspecified
Reporter | ||
Comment 4•14 years ago
|
||
Oh, if you intend to do this, please do it within the next few hours though, as this is something that should go in for the already-frozen 2.1a3, btw.
Assignee | ||
Comment 5•14 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4669 already has the intended code ;-> Requesting review from Callek, as in bug 585511.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #464867 -
Flags: review?(bugspam.Callek)
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite-
Version: unspecified → Trunk
Reporter | ||
Comment 6•14 years ago
|
||
Comment on attachment 464867 [details] [diff] [review] (Av1) Copy Firefox usage of "Array.some()" [Checkin: Comment 7] Stealing this one. Please get it landed ASAP, this is probably the reason why our alive-tests on leak test boxes are hanging and need to be manually stopped. We also shouldn't ship an alpha with this. Thanks for looking into that!
Attachment #464867 -
Flags: review?(bugspam.Callek)
Attachment #464867 -
Flags: review+
Attachment #464867 -
Flags: approval-seamonkey2.1a3+
Reporter | ||
Updated•14 years ago
|
blocking-seamonkey2.1: ? → a3+
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 464867 [details] [diff] [review] (Av1) Copy Firefox usage of "Array.some()" [Checkin: Comment 7] http://hg.mozilla.org/comm-central/rev/55314c861a36
Attachment #464867 -
Attachment description: (Av1) Copy Firefox usage of "Array.some()". → (Av1) Copy Firefox usage of "Array.some()"
[Checkin: Comment 7]
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
status-seamonkey2.1:
--- → ?
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Reporter | ||
Comment 8•14 years ago
|
||
status-seamonkey2.1 is only for wanted nominations right now, as we haven't branched, no need to set it to any value, target milestone does fine atm. :)
status-seamonkey2.1:
? → ---
Assignee | ||
Comment 11•14 years ago
|
||
(In reply to comment #6) > this is probably the reason why > our alive-tests on leak test boxes are hanging and need to be manually stopped. Indeed, this checkin fixed { http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1281643601.1281645719.10743.gz Linux comm-central-trunk debug test mochitests-1/5 on 2010/08/12 13:06:41 23733 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug426646.html | Test timed out. TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug391777.html | application timed out after 330 seconds with no output PROCESS-CRASH | /tests/content/html/document/test/test_bug391777.html | application crashed (minidump found) Thread 0 (crashed) TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | missing output line for total leaks! } on all 3 platforms :-) (In reply to comment #8) > status-seamonkey2.1 is only for wanted nominations right now, as we haven't > branched Ah, I'm used to getting unsure/wrong in this specific situation ;-<
You need to log in
before you can comment on or make changes to this bug.
Description
•