586130 - warning C4099: '$TYPE' : type name first seen using 'struct' now seen using 'class'

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

mozilla-central currently has 248 instances of this sort of warning, on windows builds:
e:\builds\moz2_slave\mozilla-central-win32-debug\build\modules\libpr0n\src\imgStatusTracker.h(43) : warning C4099: 'nsIntRect' : type name first seen using 'struct' now seen using 'class'
(based on clobber build linked in URL field)

Trivial fix -- just need to make sure that forward declarations match the actual definition, on "class" vs. "struct" terminology.

Filing this bug on fixing these.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: list of build warnings

here's a list of all these build warnings. (grepped from the log linked in URL field)

Comment 2

[Daniel Holbert [:dholbert]]

It looks like the vast majority of these are in auto-generated .h files inside of _ipdlheaders, e.g.:
> obj-firefox\ipc\ipdl\_ipdlheaders\mozilla/layers/PLayers.h(1190) : warning C4099: 'mozilla::layers::ThebesLayerAttributes' : type name first seen using 'struct' now seen using 'class'

In this case, I don't see where the 'class' declaration is coming from -- ThebesLayerAttributes is only ever declared as a struct (in PLayers.ipdl), as shown here:
http://mxr.mozilla.org/mozilla-central/search?string=ThebesLayerAttributes

Perhaps this is a bug in ipdl?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

FTR, I think this is pretty 'tarded build warning.  Anyone object to disabling it?

If so, yeah, it looks like IPDL is forward-declaring IPDL structs as |class|, but generating implementations as |struct|.  That's easy to fix.  (Bonus points for building --enable-ipdl-tests!)

Comment 4

[Benjamin Smedberg]

The IPDL warnings are taken care of in bug 607002. dholbert, feel free to do what you want with this bug.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: Updated list of warnings

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: gfx fixes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Attachment: ipc fixes

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Attachment: layout fixes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: libpr0n fixes

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: storage fixes

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Attachment: svg fixes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

The above patches fix all instances of this warning

Comment 13

[Oleg Romashin (:romaxa)]

Comment on attachment 504503 [details] [diff] [review]
gfx fixes

Correct according to original definition
http://hg.mozilla.org/mozilla-central/annotate/a66254dfa588/gfx/src/nsRect.h#l210

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 504503 [details] [diff] [review]
gfx fixes

This was obsoleted by bug 627178

Comment 15

[Shawn Wilsher :sdwilsh]

Comment on attachment 504507 [details] [diff] [review]
storage fixes

This has been bothering me, but I've been too lazy to file a bug on it.  r=sdwilsh!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 504504 [details] [diff] [review]
ipc fixes

Extremely low-risk trivial warning fixes. Requesting approval2.0 on the lot.

Comment 17

[Benjamin Smedberg]

Comment on attachment 504504 [details] [diff] [review]
ipc fixes

a=me for the patches altogether

Comment 18

[Daniel Holbert [:dholbert]]

Landed:
http://hg.mozilla.org/mozilla-central/rev/66678137e920
http://hg.mozilla.org/mozilla-central/rev/77e9633cb138
http://hg.mozilla.org/mozilla-central/rev/d689ed2ebe55
http://hg.mozilla.org/mozilla-central/rev/3e5e8dcb7a4b
http://hg.mozilla.org/mozilla-central/rev/c97a4df315a8

Thanks for fixing these!