586134 - JM: Tracer failure in tests/basic/bug525028.js on X64

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Assertion failure: LIR type error (start of writer pipeline): arg 1 of 'ui2uq' is 'immq' which has type int64 (expected int32): 0 (../nanojit/LIR.cpp:2834)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Looks like this has to do with fast native ctors.

Comment 2

[Brian Hackett [Laid off!]]

Is this on x64?  I just ran into this earlier today when porting the fast ctor patch to TM, have fix.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Yup.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

This looks like all but one of the x64 TM+JM integration bugs. If you don't mind spot-fixing for JM, I can review ASAP.

Comment 5

[Brian Hackett [Laid off!]]

Attachment: spot fix

Try this.  I'm still working on getting an x64 JM to build and test myself.

Comment 6

[Brian Hackett [Laid off!]]

Trace-tests pass for me on x64 using this patch.

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 464664 [details] [diff] [review]
spot fix

Thanks!

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Came in with a TM merge.