586182 - BWC's openFeedPrefPane: still wants to load org.mozilla.camino.preference.navigation

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix

Somehow this was missed when we cleaned up the Navigation->General stuff æons ago, yet somehow it still works (if a pane can't be found, we fall back to General, maybe?).

We should really fix it, though; that's the only reference to the that pane by that name that's left.

I notice a slight difference in behavior with my patch (with another pane selected before invoking the Feed Preferences… item in the feed icon's menu):

* Before the patch, the current pane completely loads, and then we switch to General

* After the patch, I can barely see a flash of the "selected" state around the current pane's icon before General loads (the current pane never loads; we just see the "selected" state being changed very quickly).

This seems to be an improvement, however slight ;)

Comment 1

[Stuart Morgan]

Comment on attachment 464705 [details] [diff] [review]
Fix

Oops! sr=smorgan

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/f06cab8894ac and CAMINO_2_0_BRANCH.