bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

unecessary print dialog comes up when going to Print Plus | Print Central

VERIFIED FIXED in mozilla0.9.2

Status

()

Core
Editor
P3
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: sujay, Assigned: Simon Fraser)

Tracking

Trunk
mozilla0.9.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [dialog][ui] fixed, reviewed, a=asa)

Attachments

(3 attachments)

(Reporter)

Description

18 years ago
using 10/30 build of netscape

1) launch netscape
2) launch composer
3) insert text
4) On toolbar click on Print | Print Plus | Print Central

it does two things:

a) the page loads that HP print central site
b) it brings up the print dialog

we shouldn't be bringing up the print dialog.

It works fine from File menu when doing PRint Central, doesn't bring
up the Print dialog there.

all platforms.

Comment 1

18 years ago
reassign to cmanske
Assignee: beppe → cmanske

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9

Comment 2

18 years ago
I see a second print dialog come up even when that's the first dialog I chose!
Anyone know where the code (I assume JS) is for this stuff?

Comment 3

18 years ago
moving to mozilla0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1

Comment 4

18 years ago
I don't think this is happening any more. Sujay, please retest.
Target Milestone: mozilla0.9.1 → mozilla0.9.2

Comment 5

18 years ago
I'm resolving this as fixed since it was definitely broken and it's now working 
as expected
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Target Milestone: mozilla0.9.2 → mozilla0.9
(Reporter)

Comment 6

18 years ago
this is still happening in my 4/25 build.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 7

18 years ago
ok, I was wrong.  I didn't do the steps properly.  
It's only broken from the toolbar (the menu works correctly).

This is only broken in Composer.  It works fine in Navigator.
Moving to mozilla 0.9.2 for Charley.  (Hopefully he can get to it sooner though)
Target Milestone: mozilla0.9 → mozilla0.9.2

Updated

17 years ago
Keywords: correctness
Whiteboard: [dialog][ui]

Comment 8

17 years ago
I've played with this and can't figure out how to fix it.
Since the entire menu is inserted via global overlay, there must be something
strange going on because we are not a browser.
Matt or Ben: Any ideas what could be happening?
For now, I suggest we simply don't include the 'Print Plus' submenu in the
menupopup from the toolbar button, since it is available in the File Menu.
To do that, simply don't include the id "printMenu", so the overlay won't
append the Print Plus items.
Status: REOPENED → ASSIGNED
Whiteboard: [dialog][ui] → [dialog][ui] FIX IN HAND need r=, sr=

Comment 9

17 years ago
Created attachment 38112 [details] [diff] [review]
Remove ID so Print Plus submenu isn't appended

Comment 10

17 years ago
Created attachment 38113 [details] [diff] [review]
Remove ID so Print Plus submenu isn't appended
(Assignee)

Comment 11

17 years ago
Again, I think, instead of masking the problem, we need to find out why this is 
happening. A simple breakpoint in the code that invokes the print dialog should 
be enough.
(Assignee)

Comment 12

17 years ago
The reason that you get the print dialog is that the "observes="cmd_print" is on 
the <menubutton>. So the command bubbles up from the print central menu item, and 
fires on the <menubutton>.
(Assignee)

Comment 13

17 years ago
Created attachment 38134 [details] [diff] [review]
Fix the communicatorOverlay to use event.preventBubble()
(Assignee)

Comment 14

17 years ago
Taking. r/sr please on attachment 38134 [details] [diff] [review] ?
Assignee: cmanske → sfraser
Status: ASSIGNED → NEW

Comment 15

17 years ago
sr=blake

Comment 16

17 years ago
r=cmanske
I suspected that as well adn tried moving the observer to just the print item,
but that didn't work! The prevent bubble is great.
Thanks very much!

Updated

17 years ago
Whiteboard: [dialog][ui] FIX IN HAND need r=, sr= → [dialog][ui] FIX IN HAND

Updated

17 years ago
Whiteboard: [dialog][ui] FIX IN HAND → [dialog][ui] fixed, reviewed, need a=

Comment 17

17 years ago
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989

Updated

17 years ago
Whiteboard: [dialog][ui] fixed, reviewed, need a= → [dialog][ui] fixed, reviewed, a=asa
(Assignee)

Comment 18

17 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 19

17 years ago
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.