58619 - unecessary print dialog comes up when going to Print Plus | Print Central

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 10/30 build of netscape

1) launch netscape
2) launch composer
3) insert text
4) On toolbar click on Print | Print Plus | Print Central

it does two things:

a) the page loads that HP print central site
b) it brings up the print dialog

we shouldn't be bringing up the print dialog.

It works fine from File menu when doing PRint Central, doesn't bring
up the Print dialog there.

all platforms.

Comment 1

[Kathleen :Brade]

reassign to cmanske

Comment 2

[Charles Manske]

I see a second print dialog come up even when that's the first dialog I chose!
Anyone know where the code (I assume JS) is for this stuff?

Comment 3

[rubydoo123]

moving to mozilla0.9.1

Comment 4

[Charles Manske]

I don't think this is happening any more. Sujay, please retest.

Comment 5

[Kathleen :Brade]

I'm resolving this as fixed since it was definitely broken and it's now working 
as expected

Comment 6

[sujay]

this is still happening in my 4/25 build.

Comment 7

[Kathleen :Brade]

ok, I was wrong.  I didn't do the steps properly.  
It's only broken from the toolbar (the menu works correctly).

This is only broken in Composer.  It works fine in Navigator.
Moving to mozilla 0.9.2 for Charley.  (Hopefully he can get to it sooner though)

Comment 8

[Charles Manske]

I've played with this and can't figure out how to fix it.
Since the entire menu is inserted via global overlay, there must be something
strange going on because we are not a browser.
Matt or Ben: Any ideas what could be happening?
For now, I suggest we simply don't include the 'Print Plus' submenu in the
menupopup from the toolbar button, since it is available in the File Menu.
To do that, simply don't include the id "printMenu", so the overlay won't
append the Print Plus items.

Comment 9

[Charles Manske]

Attachment: Remove ID so Print Plus submenu isn't appended

Comment 10

[Charles Manske]

Attachment: Remove ID so Print Plus submenu isn't appended

Comment 11

[Simon Fraser [no longer active]]

Again, I think, instead of masking the problem, we need to find out why this is 
happening. A simple breakpoint in the code that invokes the print dialog should 
be enough.

Comment 12

[Simon Fraser [no longer active]]

The reason that you get the print dialog is that the "observes="cmd_print" is on 
the <menubutton>. So the command bubbles up from the print central menu item, and 
fires on the <menubutton>.

Comment 13

[Simon Fraser [no longer active]]

Attachment: Fix the communicatorOverlay to use event.preventBubble()

Comment 14

[Simon Fraser [no longer active]]

Taking. r/sr please on attachment 38134 [details] [diff] [review] ?

Comment 15

[Blake Ross]

sr=blake

Comment 16

[Charles Manske]

r=cmanske
I suspected that as well adn tried moving the observer to just the print item,
but that didn't work! The prevent bubble is great.
Thanks very much!

Comment 17

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 18

[Simon Fraser [no longer active]]

Fix checked in.

Comment 19

[sujay]

verified.