586247 - Fennec smart tapping region should be dynamic according to finger touch region

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Ilkka Otsala]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100723 Ubuntu/8.04 (hardy) Firefox/3.6.8
Build Identifier: Mozilla/5.0 (X11; Linux armv7I; rv:2.0b3pre) Gecko/20100727 Firefox/4.0b3pre Fennec/2.0a1pre

If the user taps on screen with large area of finger the the tapping rectangle should be also larger.

Reproducible: Always

Steps to Reproduce:
1. Have a Fennec running on device with web page containing e.g. one link 
2. Tap on screen so that large area of screen gets covered by finger and the link is located near the edge of tapping area

Actual Results:  
Link doesn't get activated.

Expected Results:  
Link should get activated if it gets under the finger.

Smart tapping rectangle is currently static and the area that finger covers has no effect on tapping. Making tapping region dynamic according to touch rect, selecting links gets easier.

Comment 1

[Ilkka Otsala]

Attachment: Fix proposal for xulrunner

This patch contains the QT version of fetching the size of touch region and setting the values to browser.ui.touch.dyn.* preferences where Fennec can easily read those.

Comment 2

[Ilkka Otsala]

Attachment: Fix proposal for Fennec

This patch contains the using of dynamic smart tapping rectangle instead of static one. The dynamic version can be disabled by setting the browser.ui.touch.dyn.size to zero in preferences.

Comment 3

[Aakash Desai [:aakashd]]

Ilkka, can we get a testcase for your scenario? I'm having a difficult time
confirming this bug.

Comment 4

[Martijn Wargers (dead)]

Is the fix only for qt?

Comment 5

[Ilkka Otsala]

(In reply to comment #3)
> Ilkka, can we get a testcase for your scenario? I'm having a difficult time
> confirming this bug.
This is an enhancement to smart tapping functionality. The basic idea of smart tapping is described in http://starkravingfinkle.org/blog/2010/05/smart-tapping-in-mobile-firefox/
Currently the smart tapping area is static, and this enhancement makes it dynamic so that if the finger covers larger area, the smart tapping area is also larger. 

(In reply to comment #4)
> Is the fix only for qt?
Yes, this patch contains only fix for QT.

Comment 6

[Oleg Romashin (:romaxa)]

I really not sure about this patch and way of determining touch rectangle using pref set.... 

Also we have pressure value for dom event.
see http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp#2659
see http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp#2712

You can store pressure value there

also we have layout API for getting list of nodes from rect:
https://bugzilla.mozilla.org/show_bug.cgi?id=489127

Comment 7

[Oleg Romashin (:romaxa)]

Comment on attachment 465580 [details] [diff] [review]
Fix proposal for xulrunner

I think we should create new fix according to 586247#c6

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

we'll take this if it becomes ready

Comment 9

[BMO Automation]

Closing all opened bug in a graveyard component