Closed
Bug 586313
Opened 14 years ago
Closed 14 years ago
add a start/end event for panning and zooming
Categories
(Firefox for Android Graveyard :: Panning/Zooming, defect, P1)
Firefox for Android Graveyard
Panning/Zooming
Tracking
(fennec-)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | - | --- |
People
(Reporter: jmaher, Assigned: mbrubeck)
References
Details
(Whiteboard: [blocking_unittests] [fennec-checkin-posta1])
Attachments
(1 file)
965 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
For automation we need to test panning (including kinetic) and zooming. These are hard to test as these transactions take some amount of time. To work around this we are using setTimeout(func, some_large_value); It would be nice to have a ZoomStart, ZoomFinish, PanStart, PanFinish event that we could listen on.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Reporter | ||
Comment 1•14 years ago
|
||
any eta on getting this in?
Assignee | ||
Comment 2•14 years ago
|
||
I'll get this done this week.
Comment 3•14 years ago
|
||
flagging for 2.0 triage. sounds like a fix will help with simplifying zoom & panning tests
tracking-fennec: --- → ?
Reporter | ||
Comment 4•14 years ago
|
||
well, a fix is required for the browser-chrome tests to avoid using setTimeout (which means we need to fix for an r+)
Updated•14 years ago
|
tracking-fennec: ? → 2.0-
Reporter | ||
Updated•14 years ago
|
Whiteboard: [blocking_unittests]
Assignee | ||
Comment 6•14 years ago
|
||
The existing ZoomChanged event should work for this purpose. The one caveat is that it is also dispatched during page load, so you might need to ignore it then. This patch adds a new PanFinished event that fires when a pan (including any kinetic motion) stops.
Attachment #467152 -
Flags: review?(mark.finkle)
Updated•14 years ago
|
Attachment #467152 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [blocking_unittests] → [blocking_unittests] [fennec-checkin-posta1]
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/587d9cf13be0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•