586317 - Add Search Engine option is always offered even after adding

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

The Add Search Engine option continues to be present even after having added the search engine to fennec.

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b4pre) Gecko/20100810 Namoroka/4.04pre Fennec/2.0a1pre


Repro:
1) install N900, Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b4pre) Gecko/20100810 Namoroka/4.04pre Fennec/2.0a1pre
2) visit a site that has a search engine present (eg. yelp.com)
3) click Larry icon, and select "Add Search Engine"
4) Notice the option disappears from the list, and when you check awesomescreen, the search engine has been applied
5) Now go back to the site, and click Larry again.  Verify the option to Add Search Engine for that site appears

Expected:
- After adding the search engine once, it shouldnt be offered anymore.

Comment 1

[Tony Chung [:tchung]]

flagging for 2.0 triage

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch filters the already added search engines and allow to add the next one if there is many.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/4352b9348dea

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b4pre) Gecko/20100818 Namoroka/4.0b4pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b4pre) Gecko/20100818 Namoroka/4.0b4pre Fennec/2.0a1pre

Comment 5

[Ioana Chiorean]

this is reproducible for the amo search engine with the build:
Build Identifier: Mozilla /5.0 (Maemo; Linux armv7l; rv:2.0b6pre)Gecko/20100906 Firefox/4.0b6pre Fennec /2.0b1pre

Comment 6

[ahoza]

Reopen the bug.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is a regression introduce by myself in changeset http://hg.mozilla.org/mobile-browser/diff/f0f2f91b0ed8/chrome/content/browser.js

The patch also fix an error when you open the site menu because we try to access contentDocument which throw an error now.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/11e4da3cd530

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre