Closed Bug 586381 Opened 9 years ago Closed 9 years ago

Switch attribute atom storage to nsTArray

Categories

(Core :: DOM: Core & HTML, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

The inlined indexOf speeds up Contains() some; on a test that basically stresses class selector matching locally I get a 20% speedup.
Whiteboard: [needs review]
Attached patch Like soSplinter Review
Attachment #464899 - Flags: review?(jonas)
Whiteboard: [needs review] → [need review]
Comment on attachment 464899 [details] [diff] [review]
Like so

I'm not a huge fan of the typedef as it reduces readability since I bet I'll have to go find the typedef anytime you see it.

r=me either way though.
Attachment #464899 - Flags: review?(jonas) → review+
Huh.  I thought it saved a whole bunch of typing and improved readability, myself...
Comment on attachment 464899 [details] [diff] [review]
Like so

Requesting approval.  Very safe performance improvement.
Attachment #464899 - Flags: approval2.0?
Whiteboard: [need review] → [need approval]
Attachment #464899 - Flags: approval2.0? → approval2.0+
Whiteboard: [need approval] → [need landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/e96ec455618f
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need landing]
Target Milestone: --- → mozilla2.0b4
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.