586420 - Move tinderbox print of revision up higher in the Try steps so that the results are easier to find on Tinderbox

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

When a build fails during hg_update for example, the revision has not yet been printed and results in a log searching wild goose chase for the developer.  If we can move the tinderbox print step of the revision to just after the buildername print then this information would be easier to obtain.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: [needs testing] move the tinderbox print of revision into TryBuildFactory init

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Could of sworn this was a dupe but I can only find the Talos version, bug 560236.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 464933 [details] [diff] [review]
[needs testing] move the tinderbox print of revision into TryBuildFactory init

This won't work, 'got_revision' won't be set yet.  But 'revision' should work.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Can we do this for builds on all branches rather than diverge try ?

Comment 5

[Chris AtLee [:catlee]]

(In reply to comment #4)
> Can we do this for builds on all branches rather than diverge try ?

Not sure......Nightlies don't have 'revision' set (yet), so this wouldn't work for them.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

It would also be an issue for anything that uses MercurialBuildFactory.buildRevision because that will set it to something that isn't revision or got_revision, not sure if that matters.

It seems like an issue to print out what we asked for (revision) instead of what the actual code that was built is (got_revision).

From what i remember 'hg parent' is run only on try.  i wonder if the revision in the change is going to be the same as 'hg parent --template={node}'

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: [tested] print revision in the first few steps of try build

Ran this in staging - this way we can add other branches if they also have a revision at this point or develop it further somehow.  This works for now, for try.

Comment 8

[Chris AtLee [:catlee]]

Comment on attachment 464964 [details] [diff] [review]
[tested] print revision in the first few steps of try build

>diff --git a/process/factory.py b/process/factory.py
>--- a/process/factory.py
>+++ b/process/factory.py
>@@ -207,16 +207,21 @@ class MozillaBuildFactory(BuildFactory):
>         self.addStep(OutputStep(
>          name='tinderboxprint_buildername',
>          data=WithProperties('TinderboxPrint: s: %(slavename)s'),
>         ))
>         self.addStep(OutputStep(
>          name='tinderboxsummarymessage_buildername',
>          data=WithProperties('TinderboxSummaryMessage: s: %(slavename)s'),
>         ))
>+        if self.branchName in ('tryserver'):

Tiny nit: this should be ('tryserver',) I think

The rest looks good...I don't really like hardcoding the branch name here, but don't have any better ideas right now.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 464964 [details] [diff] [review]
[tested] print revision in the first few steps of try build

http://hg.mozilla.org/build/buildbotcustom/rev/7f84d13025d1