586446 - Add upload page information for Edits and Duplicates

Status: RESOLVED FIXED

(Websites Graveyard :: getpersonas.com, defect)

Description

[Shae Rivard [:crimius]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8 ( .NET CLR 3.5.30729)
Build Identifier: 

Myself, and many of the active approvers, would like to see "Do not submit the same persona more than once" in big, bold, angry letters on the upload page (or at least something noticeable, maybe not so much angry :), as well as information about the Edit function for making changes to an existing design.  Hopefully this will cut down on duplicate submissions and thus help keep wait time on approvals to a minimum.

Reproducible: Always

Comment 1

[Shae Rivard [:crimius]]

pic of what the approvers want http://tinyurl.com/5ffr4x

Comment 2

[Shae Rivard [:crimius]]

wrong link, should be this one http://tinyurl.com/329m8rv

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

Having this added ASAP would be helpful.  We do get a lot of unnecessary resubmits because of this.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> Having this added ASAP would be helpful.  We do get a lot of unnecessary
> resubmits because of this.

Is the wording in comment 2 what you want?

Comment 5

[Deb Richardson [:dria] (plz NEEDINFO)]

No, actually.  Here's some revised copy.

---
Success!

You have successfully added your Persona.  Once it's approved, you'll be able to view it in the Gallery. [link for "View Personas Gallery"].

[redbox]
Please <b>do not resubmit</b> your Persona before you receive an email notice from our review team.  It can take up to several days for reviews to be completed, so please be patient.

Click on "Dashboard" below to see how many Personas are currently in the queue awaiting approval.

If you would like to make changes to the Persona you have submitted, please use the "Edit" function after it has been approved.  

Thanks for your contribution!
[/redbox]
---

Thanks.

Comment 6

[Brandon Savage [:brandon]]

Attachment: First pass at localization

As this is my first pass at localization, I wanted to solicit feedback rather than review. Please let me know what I have done right, and what I can improve upon. If the patch is acceptable, please also let me know that and I'll put it up for review.

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 533654 [details] [diff] [review]
First pass at localization

Review of attachment 533654 [details] [diff] [review]:
-----------------------------------------------------------------

::: static/css/style.css
@@ +974,4 @@
>      margin: 0;
>  }
>  
> +.redbox {

Using semantic class names makes it easier to change the styles in the future if desired. For example, we may want this box to be orange tomorrow and so we'd want to change the class name in that case. Something like 'resubmit_warning' would be more appropriate.  This is one of the things listed at https://wiki.mozilla.org/WebDev:FrontendCodeStandards#Code_Standards

@@ +979,5 @@
> +	padding: 10px;
> +}
> +
> +div.redbox p {
> +	font-size: 1.25em;

Is there a reason why this property is not set with the selector above? It will be inherited by <p> still.

Also, I think 1.25em is quite large. How about 1.15 or 1.2?

::: server/templates/upload_success_tmpl.php
@@ +13,3 @@
>              <div id="maincontent" class="success">
>                  <h2><?= _("Success!");?></h2>
>                  <p><?= $action_sentence ?></p>

In case you didn't notice, the copy above the box needs to be changed as well.

@@ +13,4 @@
>              <div id="maincontent" class="success">
>                  <h2><?= _("Success!");?></h2>
>                  <p><?= $action_sentence ?></p>
> +                <div class="redbox">

We could make use of the existing 'tut_alert' class styles for consistency. We don't need the image and we can just override the left margin on <p>.

@@ +15,5 @@
>                  <p><?= $action_sentence ?></p>
> +                <div class="redbox">
> +                    <?php 
> +                    echo _('<p>Please <strong>do not resubmit</strong> your Persona before you receive an email notice from our review team.  It can take up to several days for reviews to be completed, so please be patient.</p>');
> +                    echo _('<p>Click on "Dashboard" below to see how many Personas are currently in the queue awaiting approval.</p>');

Could we also link "Dashboard" to the dashboard page? The URL would be an argument to sprintf since it doesn't need to be localized.

@@ +16,5 @@
> +                <div class="redbox">
> +                    <?php 
> +                    echo _('<p>Please <strong>do not resubmit</strong> your Persona before you receive an email notice from our review team.  It can take up to several days for reviews to be completed, so please be patient.</p>');
> +                    echo _('<p>Click on "Dashboard" below to see how many Personas are currently in the queue awaiting approval.</p>');
> +                    echo _('<p>If you would like to make changes to the Persona you have submitted, please use the "Edit" function after it has been approved.</p>');

I wouldn't include the <p> tags in the string to localize since I don't see any need for localizers to change them. Otherwise this is how to do L10N :)

Comment 8

[Brandon Savage [:brandon]]

Attachment: Patch v2, incorporating comments

This patch incorporates your comments. One thing of note, is that the text for the success message did NOT change according to Deb's later copy revision, so I have not made modifications there.

Comment 9

[Brandon Savage [:brandon]]

Matt, do you have time to review this? I'd like to get a push done this week.

Comment 10

[Barry Chen]

Comment on attachment 534908 [details] [diff] [review]
Patch v2, incorporating comments

+                    echo '<p>' . sprintf(_('<p>Click visit the <a href="%s">Dashboard</a> to see how many Personas are currently in the queue awaiting approval.</p>'), $locale_conf->url('/dashboard')) . '</p>';

Nested paragraphs?

Comment 11

[Brandon Savage [:brandon]]

Attachment: Revised patch

This was applied and fixes in r89983.