Last Comment Bug 586508 - Improve GL error code output
: Improve GL error code output
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: ---
Assigned To: Matt Woodrow (:mattwoodrow)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-11 16:37 PDT by Matt Woodrow (:mattwoodrow)
Modified: 2011-06-11 01:06 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add error name output (1.69 KB, patch)
2010-08-11 16:37 PDT, Matt Woodrow (:mattwoodrow)
vladimir: review+
Details | Diff | Review
Add error name output (2.94 KB, patch)
2011-04-14 12:00 PDT, Matt Woodrow (:mattwoodrow)
jacob.benoit.1: review+
Details | Diff | Review

Description Matt Woodrow (:mattwoodrow) 2010-08-11 16:37:49 PDT
Created attachment 465013 [details] [diff] [review]
Add error name output

This annoys me everytime.
Comment 1 Vladimir Vukicevic [:vlad] [:vladv] 2010-08-11 16:58:05 PDT
Comment on attachment 465013 [details] [diff] [review]
Add error name output

What, you don't know them by heart yet? :)
Comment 2 Matt Woodrow (:mattwoodrow) 2011-04-14 12:00:04 PDT
Created attachment 526066 [details] [diff] [review]
Add error name output

Ported this to the new debug layer
Comment 3 Benoit Jacob [:bjacob] (mostly away) 2011-04-18 10:44:38 PDT
Comment on attachment 526066 [details] [diff] [review]
Add error name output

R+ except for this hunk which seems to have uninitentionally made it into this patch:

>--- a/gfx/thebes/GLContextProviderCGL.mm
>+++ b/gfx/thebes/GLContextProviderCGL.mm
>@@ -161,17 +161,17 @@ public:
> 
>         default:
>             return nsnull;
>         }
>     }
> 
>     PRBool MakeCurrentImpl(PRBool aForce = PR_FALSE)
>     {
>-        if (!aForce && [mContext currentContext] == mContext) {
>+        if (!aForce && [NSOpenGLContext currentContext] == mContext) {
>             return PR_TRUE;
>         }
> 
>         if (mContext) {
>             [mContext makeCurrentContext];
>         }
>         return PR_TRUE;
>     }
Comment 4 Matt Woodrow (:mattwoodrow) 2011-04-18 16:12:08 PDT
http://hg.mozilla.org/mozilla-central/rev/f1dbb031b7c5

Note You need to log in before you can comment on or make changes to this bug.