586508 - Improve GL error code output

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Add error name output

This annoys me everytime.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 465013 [details] [diff] [review]
Add error name output

What, you don't know them by heart yet? :)

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Add error name output

Ported this to the new debug layer

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 526066 [details] [diff] [review]
Add error name output

R+ except for this hunk which seems to have uninitentionally made it into this patch:

>--- a/gfx/thebes/GLContextProviderCGL.mm
>+++ b/gfx/thebes/GLContextProviderCGL.mm
>@@ -161,17 +161,17 @@ public:
> 
>         default:
>             return nsnull;
>         }
>     }
> 
>     PRBool MakeCurrentImpl(PRBool aForce = PR_FALSE)
>     {
>-        if (!aForce && [mContext currentContext] == mContext) {
>+        if (!aForce && [NSOpenGLContext currentContext] == mContext) {
>             return PR_TRUE;
>         }
> 
>         if (mContext) {
>             [mContext makeCurrentContext];
>         }
>         return PR_TRUE;
>     }

Comment 4

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/mozilla-central/rev/f1dbb031b7c5