Improve GL error code output

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 465013 [details] [diff] [review]
Add error name output

This annoys me everytime.
(Assignee)

Updated

7 years ago
Attachment #465013 - Attachment is patch: true
Attachment #465013 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

7 years ago
Attachment #465013 - Flags: review?(vladimir)
Comment on attachment 465013 [details] [diff] [review]
Add error name output

What, you don't know them by heart yet? :)
Attachment #465013 - Flags: review?(vladimir) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 526066 [details] [diff] [review]
Add error name output

Ported this to the new debug layer
Attachment #465013 - Attachment is obsolete: true
Attachment #526066 - Flags: review?(bjacob)
Comment on attachment 526066 [details] [diff] [review]
Add error name output

R+ except for this hunk which seems to have uninitentionally made it into this patch:

>--- a/gfx/thebes/GLContextProviderCGL.mm
>+++ b/gfx/thebes/GLContextProviderCGL.mm
>@@ -161,17 +161,17 @@ public:
> 
>         default:
>             return nsnull;
>         }
>     }
> 
>     PRBool MakeCurrentImpl(PRBool aForce = PR_FALSE)
>     {
>-        if (!aForce && [mContext currentContext] == mContext) {
>+        if (!aForce && [NSOpenGLContext currentContext] == mContext) {
>             return PR_TRUE;
>         }
> 
>         if (mContext) {
>             [mContext makeCurrentContext];
>         }
>         return PR_TRUE;
>     }
Attachment #526066 - Flags: review?(bjacob) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/f1dbb031b7c5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Assignee: nobody → matt.woodrow+bugzilla
You need to log in before you can comment on or make changes to this bug.