Closed
Bug 586514
Opened 14 years ago
Closed 14 years ago
Web Console should be 100% XUL
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pcwalton, Assigned: pcwalton)
References
Details
Attachments
(1 file)
|
19.03 KB,
patch
|
dietrich
:
review+
ddahl
:
feedback+
dietrich
:
approval2.0+
|
Details | Diff | Splinter Review |
IMO the Web Console should be 100% XUL, in order to make it more in line with the rest of the Firefox UI and (more importantly) to move the timestamps to the right. (I couldn't find a way to do the latter in the HTML-XUL hybrid we currently use.)
The attached patch implements this.
Attachment #465018 -
Flags: feedback?(ddahl)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 465018 [details] [diff] [review]
[checked-in] Proposed patch.
As long as the "label" xul element allows selection (it must) this patch looks good to me. more line reduction. This should make fx-teamers happy too.
Attachment #465018 -
Flags: feedback?(ddahl) → feedback+
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Comment on attachment 465018 [details] [diff] [review]
> Proposed patch.
>
> As long as the "label" xul element allows selection (it must) this patch looks
> good to me.
It does.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #465018 -
Flags: review?(dietrich)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 465018 [details] [diff] [review]
[checked-in] Proposed patch.
r+a=me
Attachment #465018 -
Flags: review?(dietrich)
Attachment #465018 -
Flags: review+
Attachment #465018 -
Flags: approval2.0+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 465018 [details] [diff] [review]
[checked-in] Proposed patch.
http://hg.mozilla.org/mozilla-central/rev/100ec6e49c34
Attachment #465018 -
Attachment description: Proposed patch. → [checked-in] Proposed patch.
|
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•14 years ago
|
||
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•14 years ago
|
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•