Closed Bug 586535 Opened 14 years ago Closed 14 years ago

Use existing per-stream volume control on OS X

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

patch v0
1.46 KB, patch
cajbir
: review+
Details | Diff | Splinter Review 
We current implement per-stream volume control by scaling the samples as we convert them before writing them to the sa_stream.  Due to the largish buffers in the audio backend, this causes volume changes to have an annoyingly long delay before taking effect.  Bug 487504 is complaining about this on multiple platforms.

We can fix this problem easily on OS X by using the existing per-stream volume control in sydneyaudio and not implementing volume changes in nsAudioStream.

Bug 585851 will allow us to do the same thing on Windows.  Doing this on Linux requires switching to PulseAudio, which is too late and high risk for Firefox 4, but will be done in the next release.
Attached patch patch v0 — — Splinter Review 

        Attachment #465074 -
        Flags: review?(chris.double)

    
  

        Attachment #465074 -
        Flags: review?(chris.double) → review+

    
    

    
  
This bug is effectively blocking beta since bug 487504 is already blocking.

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/61004a07b318
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: