655 bytes, patch
|Details | Diff | Splinter Review|
According to dougt, this should be a monitored event queue.
I'm just wondering... do we have an instance where this is getting us into trouble?
It would be a hard thing to identify user level problems caused by this bug in http. gagan, this is another place where messages could become out of sync.
Understood... can you point me to an example that uses monitored event queues. I'd like understand what exactly needs to change.
Doug, is this just as simple as replacing CreateThreadEventQueue() with CreateMonitoredThreadEventQueue()? --darin
yes. and lots of testing. :-)
This seems potentially fairly dangerous; nominating for mozilla0.9.
In the grand scheme of things nsSyncHelper is going away in favor of a true synchronous HTTP implementation. My feeling on this bug is therefore to just leave it for now, and wait for the better solution. However, I'd like to know if people feel that this should still be "fixed" at least for the time being. AFAIK, synchronous HTTP is heavily used (at least not in mozilla).
I meant to say that synchronous HTTP is _NOT_ heavily used in mozilla.
ok.. it looks like the new sync http impl is not going to happen for a while, so i'm going to go ahead and patch up the existing impl. adding dependency on bug 59434.
nominating for moz 0.9
Created attachment 25704 [details] [diff] [review] Makes HTTP use a monitored event queue inside OpenInputStream
looks good. I am shocked that this didn't cause more problems. r=doug. please ci after I land my branch/.
only causes problems if there are other threads touching HTTP.
Fix checked in.