Closed
Bug 586600
Opened 14 years ago
Closed 14 years ago
JM: "Assertion failure: IsSaneThisObject(argv[-1].toObject())," (again)
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jbramley, Assigned: jbramley)
References
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
I get the same failure as in bug 585341 and bug 578041, but with PICs disabled. The fix is the same, I think, though I'm not familiar with the code so there may be something that I've missed.
Attachment #465168 -
Flags: review?(cdleary)
|
||
Comment 1•14 years ago
|
||
Yeah, this is https://bugzilla.mozilla.org/show_bug.cgi?id=586188. And with exactly the same patch!
I'll close my version since this one is better-integrated.
|
||
Comment 3•14 years ago
|
||
Comment on attachment 465168 [details] [diff] [review]
Fix for the non-PIC case.
Looks exactly the way that I would write it. ;-)
If two people produce exactly the same patch, that should probably count as a second review.
Do you need a checkin Jacob? I forget if you've got commit access yet.
Attachment #465168 -
Flags: review?(cdleary) → review+
|
|
||
Comment 4•14 years ago
|
||
Figured Jacob's in a different timezone so I just pushed away.
http://hg.mozilla.org/projects/jaegermonkey/rev/9230ae392642
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•