586607 - BuildContentLists should allocate contentList after getting parent

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[timeless]

// XXX Could this array just be altered in place and passed directly to
   // SetContentListFor?  We'd save space if we could pull this off.
   nsInsertionPointList* contentList = new nsInsertionPointList;
   if (!contentList) {
     data->mRv = NS_ERROR_OUT_OF_MEMORY;
     return PL_DHASH_STOP;
   }

   // Figure out the relevant content node.
   nsXBLInsertionPoint* currPoint = aData->ElementAt(0);
   nsCOMPtr<nsIContent> parent = currPoint->GetInsertionParent();
   if (!parent) {
     data->mRv = NS_ERROR_FAILURE;
leaks contentList:
     return PL_DHASH_STOP;
   }
   PRInt32 currIndex = currPoint->GetInsertionIndex();

Comment 1

[timeless]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 465181 [details] [diff] [review]
patch

Patch could have used a bigger -U (5 or so)

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 465181 [details] [diff] [review]
patch

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/53c333d9961f