586621 - Use animation-scheduling API for smooth scrollbox scrolling

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: WIP

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Neil Deakin]

Comment on attachment 465211 [details] [diff] [review]
patch

>+          const base = 2;
>+          const power = 4;
>+          const pos = timePassed >= this.duration ? 1 :
>+                      1 - (Math.pow(base * (1 - (timePassed / this.duration)), power) /
>+                           Math.pow(base, power));

Can't this just be reduced to:

const pos = timePassed >= this.duration ? 1 :
            1 - Math.pow(1 - timePassed / this.duration), 4)

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch, review comment addressed

yeah, it's identical

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 466311 [details] [diff] [review]
patch, review comment addressed

What's our test coverage like on this?

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> What's our test coverage like on this?

As far as I know, we have tests for scrollbox scrolling only with smooth scrolling disabled. This ensures that the distance needed to scroll to an element is correct, since this is using the same code path with and without smooth scrolling. But we don't test how smooth scrolling itself operates.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/5c5c3bf8dfeb