586648 - NS_NewXHTMLParanoidFragmentSink should call nsXHTMLParanoidFragmentSink::Init before allocating it

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[timeless]

NS_NewXHTMLParanoidFragmentSink(nsIFragmentContentSink** aResult)
 {
   nsXHTMLParanoidFragmentSink* it = new nsXHTMLParanoidFragmentSink();
   if (!it) {
     return NS_ERROR_OUT_OF_MEMORY;
   }
   nsresult rv = nsXHTMLParanoidFragmentSink::Init();
leaks it:
   NS_ENSURE_SUCCESS(rv, rv);
   NS_ADDREF(*aResult = it);

Comment 1

[timeless]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 465233 [details] [diff] [review]
patch

new is infallible. Remove the null check if something.

Comment 3

[timeless]

Attachment: less code

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 466575 [details] [diff] [review]
less code

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0c3b638b4977