586671 - AffixMgr::parse_convtable leaks pattern/pattern2 if it can't create both

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[timeless]

3510 	        char * pattern = NULL;
3511 	        char * pattern2 = NULL;
3512 	        piece = mystrsep(&tp, 0);
3513 	        while (piece) {
...
3525 	                  case 1: { pattern = mystrrep(mystrdup(piece),"_"," "); break; }
3526 	                  case 2: { 
3527 	                    pattern2 = mystrrep(mystrdup(piece),"_"," ");
...
3535 	        }
3536 	        if (!pattern || !pattern2) {
3537 	             HUNSPELL_WARNING(stderr, "error: line %d: table is corrupt\n", af->getlinenum());
leaks pattern or pattern2:
3538 	             return 1;
3539 	        }

Comment 1

[timeless]

Attachment: patch

please note that this file does not have anything resembling an indentation style.

Comment 2

[Caolan McNamara]

patch now committed to upstream hunspell

Comment 3

[Caolan McNamara]

don't seem to have sufficient mojo to set patch review flag to +

Comment 4

[timeless]

re comment 3: fixed; mojo granted :)

Comment 5

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/aacc3b418049

Comment 6

[(no longer active)]

I think you need to request branch approval, Ryan, if you want this on 1.9.2.