Closed
Bug 586671
Opened 14 years ago
Closed 14 years ago
AffixMgr::parse_convtable leaks pattern/pattern2 if it can't create both
Categories
(Core :: Spelling checker, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | ? |
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, memory-leak, Whiteboard: [fixed-in-hunspell-1.2.13])
Attachments
(1 file)
|
1.04 KB,
patch
|
RyanVM
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
3510 char * pattern = NULL;
3511 char * pattern2 = NULL;
3512 piece = mystrsep(&tp, 0);
3513 while (piece) {
...
3525 case 1: { pattern = mystrrep(mystrdup(piece),"_"," "); break; }
3526 case 2: {
3527 pattern2 = mystrrep(mystrdup(piece),"_"," ");
...
3535 }
3536 if (!pattern || !pattern2) {
3537 HUNSPELL_WARNING(stderr, "error: line %d: table is corrupt\n", af->getlinenum());
leaks pattern or pattern2:
3538 return 1;
3539 }
please note that this file does not have anything resembling an indentation style.
|
||
Updated•14 years ago
|
Attachment #465281 -
Flags: review?(ryanvm) → review?(caolanm)
|
||
Comment 2•14 years ago
|
||
patch now committed to upstream hunspell
|
|
||
Comment 3•14 years ago
|
||
don't seem to have sufficient mojo to set patch review flag to +
|
|
||
Updated•14 years ago
|
Attachment #465281 -
Flags: review?(caolanm) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13]
|
|
||
Updated•14 years ago
|
Depends on: hunspell-1.3.2
|
||
Updated•14 years ago
|
Attachment #465281 -
Flags: approval2.0?
Attachment #465281 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13] → [fixed-in-hunspell-1.2.13][needs landing]
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/aacc3b418049
|
|
||
Updated•14 years ago
|
status1.9.2:
--- → ?
Whiteboard: [fixed-in-hunspell-1.2.13][needs landing] → [fixed-in-hunspell-1.2.13]
|
|
||
Comment 6•14 years ago
|
||
I think you need to request branch approval, Ryan, if you want this on 1.9.2.
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•