Closed
Bug 586686
Opened 14 years ago
Closed 13 years ago
Hunspell::spellml + Hunspell::get_xml_list are messy
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | ? |
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, memory-leak, Whiteboard: [fixed-in-hunspell-1.2.13])
Attachments
(1 file)
|
1.50 KB,
patch
|
RyanVM
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
So, I'd just like to rewrite a small section. Please note that freelist() frees items 0..n-1 iff they are non null.
|
||
Updated•14 years ago
|
Attachment #465289 -
Flags: review?(ryanvm) → review?(caolanm)
|
||
Comment 2•14 years ago
|
||
looks reasonable, committed upstream. Don't have sufficient mojo to review + here. I don't think mozilla uses this particular api trapdoor anyway.
|
|
||
Updated•14 years ago
|
Attachment #465289 -
Flags: review?(caolanm) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13]
|
|
||
Updated•14 years ago
|
Depends on: hunspell-1.3.2
|
||
Updated•13 years ago
|
Attachment #465289 -
Flags: approval2.0?
Attachment #465289 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•13 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13] → [fixed-in-hunspell-1.2.13][needs landing]
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/8cfa767f666c
Keywords: checkin-needed
|
|
||
Updated•13 years ago
|
|
|
||
Updated•13 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13][needs landing] → [fixed-in-hunspell-1.2.13]
|
|
||
Comment 4•13 years ago
|
||
I think you need to request branch approval, Ryan, if you want this on 1.9.2.
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•