586731 - jsd_NewSourceText leaks new_url_string ifndef LIVEWIRE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

378  	jsd_NewSourceText(JSDContext* jsdc, const char* url)

381  	    const char* new_url_string;

385  	#ifdef LIVEWIRE
386  	    new_url_string = url; /* we take ownership of alloc'd string */
387  	#else
388  	    new_url_string = jsd_BuildNormalizedURL(url);
389  	#endif

393  	    jsdsrc = jsd_FindSourceForURL(jsdc, new_url_string);

395  	    if( jsdsrc )
396  	    {
397  	        if( jsdsrc->doingEval )
398  	        {
399  	#ifdef LIVEWIRE
400  	            free((char*)new_url_string);
401  	#endif
402  	            JSD_UNLOCK_SOURCE_TEXT(jsdc);
leak:
403  	            return NULL;
404  	        }

this arranges to unconditioally free new_url_string:
409  	    jsdsrc = _addSource( jsdc, new_url_string );

Comment 1

[timeless]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 465336 [details] [diff] [review]
patch

I don't think I'm a good person for this review, sorry.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 465336 [details] [diff] [review]
patch

Can we make sure this hasn't bitrotted? Then renominate for approval.

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/473318f3853a