586799 - Incubator embedding: MozView should auto-connect

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Tatiana Meshkova (:tatiana)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8
Build Identifier: 

see bug #530013

Reproducible: Always

Comment 1

[Tatiana Meshkova (:tatiana)]

Attachment: patch

Comment 2

[Tatiana Meshkova (:tatiana)]

Attachment: patch

added missing NS_OK for succeed case

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 465851 [details]
patch

Why do we want to force the app to connect? Couldn't we just expose the ForceOnline method from the embedding API? Honestly, it's simple enough we should just let the embedding app implement the ForceOnline method and call it when needed.

I really don't think we need this in the API. Tell me why you think we do.

Comment 4

[Oleg Romashin (:romaxa)]

This forceOnline and connectivity relationship is not very obvious for embeders, and somehow/somewhere we should document it clearly that ForceOnline is must be called before any network call to get connectivity working.

I agree that moving of this method is correct to make it similar to fennec application (it is moved there in Utils.js).

Comment 5

[Oleg Romashin (:romaxa)]

Comment on attachment 465851 [details]
patch

Yep, move it to test application code.

Comment 6

[Tatiana Meshkova (:tatiana)]

Attachment: patch

moved ForceOnline() to test app code

Comment 7

[Oleg Romashin (:romaxa)]

Comment on attachment 466427 [details] [diff] [review]
patch

I think this is fine for test app, and showing clearly that it must be here.

Comment 8

[Tatiana Meshkova (:tatiana)]

Attachment: test patch

updated qt test ForceOnline() patch since parent patch is changed

Comment 9

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/incubator/embedding/rev/fd2905d0088c