Closed Bug 586967 Opened 14 years ago Closed 14 years ago

CERT_CreateCertificate leaks arena if PORT_ArenaZAlloc fails

Categories

(NSS :: Libraries, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
3.12.8

People

(Reporter: timeless, Assigned: timeless)

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file)

I know that this shouldn't happen in theory, but Coverity is complaining that the code does a bad job of pretending it can happen.
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #465636 - Flags: review?(nelson)
Comment on attachment 465636 [details] [diff] [review]
patch

I think coverity is right to complain about this.
Thanks for the patch.  r+, to commit later.
Attachment #465636 - Flags: review?(nelson) → review+
Priority: -- → P2
Target Milestone: --- → 3.12.8
Checking in certhigh/certreq.c; new revision: 1.9; previous revision: 1.8
Mass checkin of Timeless's coverity fixes on 3.12 branch:

cmd/lib/secutil.c;           new revision: 1.99.2.1; previous revision: 1.99
cmd/lib/secutil.h;           new revision: 1.32.2.1; previous revision: 1.32
cmd/certutil/certutil.c;     new revision: 1.149.2.1; previous revision: 1.149
lib/certhigh/certhtml.c;     new revision: 1.8.66.1; previous revision: 1.8
lib/certhigh/certreq.c;      new revision: 1.8.56.1; previous revision: 1.8
lib/jar/jar.h;               new revision: 1.6.4.1; previous revision: 1.6
lib/smime/cmssiginfo.c;      new revision: 1.32.2.1; previous revision: 1.32
lib/pk11wrap/debug_module.c; new revision: 1.15.2.1; previous revision: 1.15
lib/crmf/servget.c;          new revision: 1.5.66.1; previous revision: 1.5
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Priority: P2 → P3
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: